Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 806473006: namespace {} trick for SK_DECLARE_STATIC_ONCE (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

namespace {} trick for SK_DECLARE_STATIC_ONCE Like all our other SK_DECLARE_STATIC_*, it's usually not a thread-safe thing to put inside a function. Adding namespace {} prevents that syntactically. Needs https://codereview.chromium.org/841263004/ to land first. BUG=chromium:447890 No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/199ba8e19b0cafb37eea3beab162bc4b52728fff

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M include/core/SkOnce.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkGlobalInitialization_chromium.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkEventTracer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/win/SkDWrite.cpp View 1 chunk +1 line, -2 lines 1 comment Download
M tests/OnceTest.cpp View 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
5 years, 11 months ago (2015-01-12 19:22:26 UTC) #2
bungeman-skia
lgtm, with one nitish. https://codereview.chromium.org/806473006/diff/1/src/utils/win/SkDWrite.cpp File src/utils/win/SkDWrite.cpp (right): https://codereview.chromium.org/806473006/diff/1/src/utils/win/SkDWrite.cpp#newcode44 src/utils/win/SkDWrite.cpp:44: SK_DECLARE_STATIC_ONCE(once); 'once' seems like a ...
5 years, 11 months ago (2015-01-12 19:36:37 UTC) #3
mtklein
> https://codereview.chromium.org/806473006/diff/1/src/utils/win/SkDWrite.cpp#newcode44 > src/utils/win/SkDWrite.cpp:44: SK_DECLARE_STATIC_ONCE(once); > 'once' seems like a rather generic thing to put ...
5 years, 11 months ago (2015-01-13 15:28:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806473006/1
5 years, 11 months ago (2015-01-13 16:25:30 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 16:40:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/199ba8e19b0cafb37eea3beab162bc4b52728fff

Powered by Google App Engine
This is Rietveld 408576698