namespace {} trick for SK_DECLARE_STATIC_ONCE

src/utils/win/SkDWrite.cpp

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkDWrite.h"
 #include "SkHRESULT.h"
 #include "SkOnce.h"
@@ skipping 23 matching lines @@
     }
 
     HRVM(dWriteCreateFactoryProc(DWRITE_FACTORY_TYPE_SHARED,
                                  __uuidof(IDWriteFactory),
                                  reinterpret_cast<IUnknown**>(factory)),
          "Could not create DirectWrite factory.");
     atexit(release_dwrite_factory);
 }
 
 
+SK_DECLARE_STATIC_ONCE(once);

[bungeman-skia, 2015/01/12 19:36:37]

'once' seems like a rather generic thing to put at global scope like this, but I
don't see any good reason to change it... ('gOnce' isn't really any better). It
was quite nice when these were scoped.

 IDWriteFactory* sk_get_dwrite_factory() {
-    SK_DECLARE_STATIC_ONCE(once);
     SkOnce(&once, create_dwrite_factory, &gDWriteFactory);
-
     return gDWriteFactory;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // String conversion
 
 /** Converts a utf8 string to a WCHAR string. */
 HRESULT sk_cstring_to_wchar(const char* skname, SkSMallocWCHAR* name) {
     int wlen = MultiByteToWideChar(CP_UTF8, 0, skname, -1, NULL, 0);
     if (0 == wlen) {
@@ skipping 58 matching lines @@
     );
     if (!*proc) {
         HRESULT hr = HRESULT_FROM_WIN32(GetLastError());
         if (!IS_ERROR(hr)) {
             hr = ERROR_PROC_NOT_FOUND;
         }
         return hr;
     }
     return S_OK;
 }