Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 806423002: [WebSocket] Remove unnecessary harmful check on the Page instance associated with the Document (Closed)

Created:
6 years ago by tyoshino (SeeGerritForStatus)
Modified:
6 years ago
Reviewers:
Mike West, yhirano
CC:
yhirano+watch_chromium.org, tyoshino+watch_chromium.org, Mike West
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[WebSocket] Remove unnecessary harmful check on the Page instance associated with the Document Blink r148941 (https://src.chromium.org/viewvc/blink?revision=148941&view=revision) separeted createUniqueIdentifier() from ProgressTracker. So, we no longer need to check if the Page is null or not. Blink r160310 (https://src.chromium.org/viewvc/blink?revision=160310&view=revision) added NewWebSocketChannelImpl::document() and it expects m_identifier to be non-null. But it isn't when the Page was null on construction. This leads to crash on document() call. Let's just remove the Page null-ness check. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/websockets/DocumentWebSocketChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
tyoshino (SeeGerritForStatus)
6 years ago (2014-12-17 09:19:52 UTC) #2
tyoshino (SeeGerritForStatus)
On 2014/12/17 09:19:52, tyoshino wrote: This is needed to land https://codereview.chromium.org/785933005/
6 years ago (2014-12-17 09:24:08 UTC) #3
Mike West
LGTM.
6 years ago (2014-12-17 09:36:26 UTC) #5
yhirano
lgtm NewWebSocketChannel => NewWebSocketChannelImpl
6 years ago (2014-12-17 10:03:21 UTC) #6
tyoshino (SeeGerritForStatus)
On 2014/12/17 10:03:21, yhirano wrote: > lgtm > NewWebSocketChannel => NewWebSocketChannelImpl Done
6 years ago (2014-12-17 10:23:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806423002/1
6 years ago (2014-12-17 10:24:17 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-17 11:33:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187366

Powered by Google App Engine
This is Rietveld 408576698