Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 806423002: [WebSocket] Remove unnecessary harmful check on the Page instance associated with the Document (Closed)

6 years ago by tyoshino (SeeGerritForStatus)
6 years ago
Mike West, yhirano
CC:,, Mike West
Base URL:
Target Ref:


[WebSocket] Remove unnecessary harmful check on the Page instance associated with the Document Blink r148941 ( separeted createUniqueIdentifier() from ProgressTracker. So, we no longer need to check if the Page is null or not. Blink r160310 ( added NewWebSocketChannelImpl::document() and it expects m_identifier to be non-null. But it isn't when the Page was null on construction. This leads to crash on document() call. Let's just remove the Page null-ness check. BUG=none Committed:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/websockets/DocumentWebSocketChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download


Total messages: 10 (3 generated)
tyoshino (SeeGerritForStatus)
6 years ago (2014-12-17 09:19:52 UTC) #2
tyoshino (SeeGerritForStatus)
On 2014/12/17 09:19:52, tyoshino wrote: This is needed to land
6 years ago (2014-12-17 09:24:08 UTC) #3
Mike West
6 years ago (2014-12-17 09:36:26 UTC) #5
lgtm NewWebSocketChannel => NewWebSocketChannelImpl
6 years ago (2014-12-17 10:03:21 UTC) #6
tyoshino (SeeGerritForStatus)
On 2014/12/17 10:03:21, yhirano wrote: > lgtm > NewWebSocketChannel => NewWebSocketChannelImpl Done
6 years ago (2014-12-17 10:23:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at
6 years ago (2014-12-17 10:24:17 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-17 11:33:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as

Powered by Google App Engine
This is Rietveld 408576698