Source/modules/websockets/DocumentWebSocketChannel.cpp - Issue 806423002: [WebSocket] Remove unnecessary harmful check on the Page instance associated with the Document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/DocumentWebSocketChannel.cpp

Issue 806423002: [WebSocket] Remove unnecessary harmful check on the Page instance associated with the Document (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/websockets/DocumentWebSocketChannel.cpp

diff --git a/Source/modules/websockets/DocumentWebSocketChannel.cpp b/Source/modules/websockets/DocumentWebSocketChannel.cpp

index d25828afc0a47a5d7d76584add0eaabfee871ac9..dd2d1e035bc1e8e3aac7e8299d52eeebd456e8ce 100644

--- a/Source/modules/websockets/DocumentWebSocketChannel.cpp

+++ b/Source/modules/websockets/DocumentWebSocketChannel.cpp

@@ -121,7 +121,7 @@ DocumentWebSocketChannel::DocumentWebSocketChannel(ExecutionContext* context, We

, m_sourceURLAtConstruction(sourceURL)

, m_lineNumberAtConstruction(lineNumber)

{

- if (context->isDocument() && toDocument(context)->page())

+ if (context->isDocument())

m_identifier = createUniqueIdentifier();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »