Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 785933005: Check that ExecutionContext and LocalFrame pointers are not null before getting shouldBypassMainWor… (Closed)

Created:
6 years ago by tyoshino (SeeGerritForStatus)
Modified:
6 years ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Check that ExecutionContext and LocalFrame pointers are not null before getting shouldBypassMainWorldCSP via those pointers This is fix for the case of WebSocket, but EventSource is also fixed as a bonus. BUG=439513 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187441

Patch Set 1 #

Patch Set 2 : Added a layout test #

Patch Set 3 : Rebase #

Patch Set 4 : Fixed expectation file. Was empty #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -13 lines) Patch
A LayoutTests/http/tests/websocket/construct-in-detached-frame.html View 1 1 chunk +19 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/websocket/construct-in-detached-frame-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/websocket/resources/construct-in-detached-frame.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/page/EventSource.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M Source/modules/websockets/DOMWebSocket.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
tyoshino (SeeGerritForStatus)
6 years ago (2014-12-09 05:47:34 UTC) #2
Mike West
LGTM!
6 years ago (2014-12-09 08:34:03 UTC) #4
Mike West
Actually, before I throw this to the CQ for you, is it possible to add ...
6 years ago (2014-12-09 08:34:38 UTC) #6
tyoshino (SeeGerritForStatus)
On 2014/12/09 08:34:38, Mike West wrote: > Actually, before I throw this to the CQ ...
6 years ago (2014-12-17 09:23:31 UTC) #7
Mike West
On 2014/12/17 09:23:31, tyoshino wrote: > On 2014/12/09 08:34:38, Mike West wrote: > > Actually, ...
6 years ago (2014-12-17 09:37:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785933005/40001
6 years ago (2014-12-17 13:32:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/35922)
6 years ago (2014-12-17 15:48:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785933005/40001
6 years ago (2014-12-18 06:18:49 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42498)
6 years ago (2014-12-18 07:55:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785933005/60001
6 years ago (2014-12-18 08:03:37 UTC) #18
commit-bot: I haz the power
6 years ago (2014-12-18 09:12:01 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187441

Powered by Google App Engine
This is Rietveld 408576698