Fix few targets in UI during GN build on Windows.

Fix few targets in UI during GN build on Windows.

BUG=None
TEST=gn gen out_gn/Debug && ninja -C out_gn/Debug
R=sky@chromium.org
TBR=brettw@chromium.org

Committed: https://crrev.com/f06c5c820f36a11120a58de65d8889cd7f870287
Cr-Commit-Position: refs/heads/master@{#308711}

[Slava Chigrin, 2014-12-16 12:47:58]

Patchset #1 (id:1) has been deleted

[Slava Chigrin, 2014-12-16 12:48:54]

vchigrin@yandex-team.ru changed reviewers:
+ sky@chromium.org

[tfarina, 2014-12-16 13:14:08]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2014-12-16 13:14:09]

https://codereview.chromium.org/806183002/diff/20001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/806183002/diff/20001/BUILD.gn#oldcode356
BUILD.gn:356: "//ui/base",
Why are you removing these entries?

https://codereview.chromium.org/806183002/diff/20001/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/806183002/diff/20001/ui/base/BUILD.gn#newcode830
ui/base/BUILD.gn:830: "dragdrop/os_exchange_data_provider_aurax11_unittest.cc",
Don't we have a filename filter for x11?

[Slava Chigrin, 2014-12-16 13:32:34]

Thank you for review. If anybody considering approving these changes, please,
trigger win8_chromium_gn_rel and win8_chromium_gn_dbg trybots so we'll check
that these changes do not break anything on bots (I checked patch only locally,
and unfortunately I have no rights for triggering try jobs).

https://codereview.chromium.org/806183002/diff/20001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/806183002/diff/20001/BUILD.gn#oldcode356
BUILD.gn:356: "//ui/base",
On 2014/12/16 13:14:08, tfarina wrote:
> Why are you removing these entries?
This is a part of  "deps -=" list, so removing is in fact enabling targets.
As far as I understand, these targets are disabled temporerily in
https://codereview.chromium.org/709593004 , until all GN targets will not be
fixed.

https://codereview.chromium.org/806183002/diff/20001/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/806183002/diff/20001/ui/base/BUILD.gn#newcode830
ui/base/BUILD.gn:830: "dragdrop/os_exchange_data_provider_aurax11_unittest.cc",
On 2014/12/16 13:14:08, tfarina wrote:
> Don't we have a filename filter for x11?
As far as I understand, file name filter for GN is set up here
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...
, during sources_assignment_filter  setup. Seems, there are no filters, relevant
to x11 in file names. And comment there forbids adding more filters.

[tfarina, 2014-12-16 13:42:46]

https://codereview.chromium.org/806183002/diff/20001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/806183002/diff/20001/BUILD.gn#oldcode356
BUILD.gn:356: "//ui/base",
OK, I see. With this you are enabling those targets on Windows. As you made sure
they build there. Is that right?

[Slava Chigrin, 2014-12-16 13:48:30]

On 2014/12/16 13:42:46, tfarina wrote:
> https://codereview.chromium.org/806183002/diff/20001/BUILD.gn
> File BUILD.gn (left):
> 
> https://codereview.chromium.org/806183002/diff/20001/BUILD.gn#oldcode356
> BUILD.gn:356: "//ui/base",
> OK, I see. With this you are enabling those targets on Windows. As you made
sure
> they build there. Is that right?

Yes, I tried locally, building all targets (running ninja without specifying
target, or specifying "all").

[Slava Chigrin, 2014-12-16 14:21:51]

https://codereview.chromium.org/806183002/diff/20001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/806183002/diff/20001/BUILD.gn#oldcode356
BUILD.gn:356: "//ui/base",
On 2014/12/16 13:42:46, tfarina wrote:
> OK, I see. With this you are enabling those targets on Windows. As you made
sure
> they build there. Is that right?

Yes, and try jobs are completed successfully too.

[sky, 2014-12-16 16:42:40]

LGTM you can do the cleanup I mention here separately.

https://codereview.chromium.org/806183002/diff/20001/ui/aura/BUILD.gn
File ui/aura/BUILD.gn (right):

https://codereview.chromium.org/806183002/diff/20001/ui/aura/BUILD.gn#newcode195
ui/aura/BUILD.gn:195: if (use_aura) {
As you are cleaning things up, can you get rid of this conditional and move
196/200 to their respective places? I can't see as how a use_aura conditional
makes sense in an aura build file.

[Slava Chigrin, 2014-12-16 16:48:48]

The CQ bit was checked by vchigrin@yandex-team.ru

[commit-bot: I haz the power, 2014-12-16 16:49:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/806183002/20001

[commit-bot: I haz the power, 2014-12-16 16:55:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 16:55:30]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Slava Chigrin, 2014-12-16 16:58:52]

vchigrin@yandex-team.ru changed reviewers:
+ brettw@chromium.org

[Slava Chigrin, 2014-12-16 17:15:39]

Forgot about root BUILD.gn owner, added brettw@

[tfarina, 2014-12-17 01:17:49]

lgtm

I'm TBRing Brett for the top-level BUILD.gn file.

Brett, please rubber stamp this when you can.

Pushing to CQ.

Regards,

[tfarina, 2014-12-17 01:18:03]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-12-17 01:19:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/806183002/20001

[commit-bot: I haz the power, 2014-12-17 01:23:47]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2014-12-17 01:24:35]

Patchset 1 (id:??) landed as
https://crrev.com/f06c5c820f36a11120a58de65d8889cd7f870287
Cr-Commit-Position: refs/heads/master@{#308711}

[tfarina, 2014-12-17 22:50:38]

https://codereview.chromium.org/806183002/diff/20001/ui/aura/BUILD.gn
File ui/aura/BUILD.gn (right):

https://codereview.chromium.org/806183002/diff/20001/ui/aura/BUILD.gn#newcode195
ui/aura/BUILD.gn:195: if (use_aura) {
On 2014/12/16 16:42:40, sky wrote:
> As you are cleaning things up, can you get rid of this conditional and move
> 196/200 to their respective places? I can't see as how a use_aura conditional
> makes sense in an aura build file.

I took care of this in CL https://codereview.chromium.org/787403003/. PTAL