Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/aura/BUILD.gn

Issue 806183002: Fix few targets in UI during GN build on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« BUILD.gn ('K') | « BUILD.gn ('k') | ui/base/BUILD.gn » ('j') | ui/base/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/BUILD.gn
diff --git a/ui/aura/BUILD.gn b/ui/aura/BUILD.gn
index b845d5159ef867d52f6c9a1f67db414948123231..c06a9e1dc3d8b1ac68d5a3bce07fe9bb89f843e7 100644
--- a/ui/aura/BUILD.gn
+++ b/ui/aura/BUILD.gn
@@ -181,7 +181,6 @@ source_set("test_support") {
"//ui/events:test_support",
"//ui/gfx",
"//ui/gfx/geometry",
- "//ui/gfx/x",
"//ui/wm",
]
@@ -189,6 +188,10 @@ source_set("test_support") {
cflags = [ "/wd4267" ] # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
}
+ if (use_x11) {
+ deps += [ "//ui/gfx/x" ]
+ }
+
if (use_aura) {
sky 2014/12/16 16:42:40 As you are cleaning things up, can you get rid of
tfarina 2014/12/17 22:50:37 I took care of this in CL https://codereview.chrom
if (is_win) {
sources += [ "test/ui_controls_factory_aurawin.cc" ]
« BUILD.gn ('K') | « BUILD.gn ('k') | ui/base/BUILD.gn » ('j') | ui/base/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698