BUILD.gn - Issue 806183002: Fix few targets in UI during GN build on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 806183002: Fix few targets in UI during GN build on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 327088956275c92b101abca2b2288a81fbeba266..bf3f8d937590557d071f986b44030536f70b341a 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -353,10 +353,6 @@ group("root") {

"//ui/accessibility",

"//ui/app_list",

"//ui/aura",

- "//ui/base",

tfarina 2014/12/16 13:14:08 Why are you removing these entries?

Slava Chigrin 2014/12/16 13:32:34 This is a part of "deps -=" list, so removing is

tfarina 2014/12/16 13:42:46 OK, I see. With this you are enabling those target

Slava Chigrin 2014/12/16 14:21:51 Yes, and try jobs are completed successfully too.

- "//ui/display",

- "//ui/events",

- "//ui/gfx",

"//ui/gl",

"//ui/keyboard",

"//ui/native_theme",

« no previous file with comments | « no previous file | ui/aura/BUILD.gn » ('j') | ui/aura/BUILD.gn » ('J')