Make *some* version of the Win GN build work.

Make *some* version of the Win GN build work.

R=scottmg@chromium.org, brettw@chromium.org
BUG=354261
Committed: https://crrev.com/43760591658239084cf4b92ec4dd4decbb9c5fe6
Cr-Commit-Position: refs/heads/master@{#303366}

[Dirk Pranke, 2014-11-07 03:26:55]

This is a work in progress, but it's pretty close. I have to clean up a few
things in the leaf build files -- add comments and so forth -- and file a couple
bugs for upstream cleanup, but this should at least work.

[scottmg, 2014-11-07 03:38:11]

lgtm

https://codereview.chromium.org/709593004/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/709593004/diff/1/build/config/compiler/BUILD....
build/config/compiler/BUILD.gn:924: # build, or on all the time? For now we'll
require official build so
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...

[Dirk Pranke, 2014-11-07 03:43:26]

https://codereview.chromium.org/709593004/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/709593004/diff/1/build/config/compiler/BUILD....
build/config/compiler/BUILD.gn:924: # build, or on all the time? For now we'll
require official build so
On 2014/11/07 03:38:11, scottmg wrote:
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...

There seemed to be a few other places that explicitly defined /GL in addition to
common.gypi, and those were the cases I was worried about (in GN, we may need to
define another config to pick them up).

[brettw, 2014-11-07 16:17:54]

lgtm

https://codereview.chromium.org/709593004/diff/20001/build/config/allocator.gni
File build/config/allocator.gni (right):

https://codereview.chromium.org/709593004/diff/20001/build/config/allocator.g...
build/config/allocator.gni:5: # TODO(GYP): Make tcmalloc work on win debug.
Does it work on Win release? If so, we should change this condition. If not, we
should change this comment.

[Dirk Pranke, 2014-11-07 17:09:42]

https://codereview.chromium.org/709593004/diff/20001/build/config/allocator.gni
File build/config/allocator.gni (right):

https://codereview.chromium.org/709593004/diff/20001/build/config/allocator.g...
build/config/allocator.gni:5: # TODO(GYP): Make tcmalloc work on win debug.
On 2014/11/07 16:17:54, brettw wrote:
> Does it work on Win release? If so, we should change this condition. If not,
we
> should change this comment.

I will double-check and update it accordingly.

[Dirk Pranke, 2014-11-08 00:29:25]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2014-11-08 00:30:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/709593004/40001

[Dirk Pranke, 2014-11-08 01:52:16]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2014-11-08 01:53:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/709593004/80001

[commit-bot: I haz the power, 2014-11-08 03:00:06]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-11-08 03:00:40]

Patchset 5 (id:??) landed as
https://crrev.com/43760591658239084cf4b92ec4dd4decbb9c5fe6
Cr-Commit-Position: refs/heads/master@{#303366}

[Nico, 2014-11-18 19:13:43]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2014-11-18 19:13:44]

https://codereview.chromium.org/709593004/diff/80001/third_party/zlib/BUILD.gn
File third_party/zlib/BUILD.gn (right):

https://codereview.chromium.org/709593004/diff/80001/third_party/zlib/BUILD.g...
third_party/zlib/BUILD.gn:10: if (!is_win && (cpu_arch == "x86" || cpu_arch ==
"x64")) {
This isn't correct. The gyp version does use crc_folder.c and fill_window_sse.c
on Windows, it just doesn't need the -msse4.2 flags and whatnot.

[Dirk Pranke, 2014-11-18 20:37:45]

https://codereview.chromium.org/709593004/diff/80001/third_party/zlib/BUILD.gn
File third_party/zlib/BUILD.gn (right):

https://codereview.chromium.org/709593004/diff/80001/third_party/zlib/BUILD.g...
third_party/zlib/BUILD.gn:10: if (!is_win && (cpu_arch == "x86" || cpu_arch ==
"x64")) {
On 2014/11/18 19:13:43, Nico wrote:
> This isn't correct. The gyp version does use crc_folder.c and
fill_window_sse.c
> on Windows, it just doesn't need the -msse4.2 flags and whatnot.

Okay, good to know. I'll try to fix that in a follow up patch.

I fully expect many of these initial patches to be wrong in some dimension;
often we're just trying to get things to compile *at all*, and we'll have to go
and patch things later.

This is not to say that we shouldn't try to get things right from the start,
just that we won't always be successful.