Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 802473003: Fix references to ui/gfx headers in a*/. (Closed)

Created:
6 years ago by Avi (use Gerrit)
Modified:
6 years ago
CC:
chromium-reviews, jam, sadrul, derat+watch_chromium.org, tfarina, tdanderson+overview_chromium.org, dcheng, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, stevenjb+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -146 lines) Patch
M android_webview/browser/icon_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/renderer_host/aw_render_view_host_ext.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/common/print_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/common/print_messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/external_video_surface_container_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/renderer/aw_render_view_ext.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/renderer/print_web_view_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M apps/ui/views/app_window_frame_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/autoclick/autoclick_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/desktop_background/desktop_background_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/dip_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_info.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/display_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/display_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/mirror_window_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mouse_cursor_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/resolution_notification_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/resolution_notification_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/root_window_transformers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/root_window_transformers_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/drag_drop/drag_image_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/first_run/first_run_helper_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/frame/caption_buttons/frame_size_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/custom_frame_view_ash.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/frame/custom_frame_view_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/default_header_painter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/header_painter_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/host/ash_window_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/host/transformer_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/magnification_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/partial_magnification_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/popup_message.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/popup_message.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/rotator/screen_rotation.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/rotator/screen_rotation.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/overflow_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_bezel_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_tooltip_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/power_status.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/special_popup_row.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/special_popup_row.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/throbber_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_background_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_popup_label_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_popup_label_button_border.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/button_from_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/user_card_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/mirror_window_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_screenshot_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_hud_debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_hud_projection.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_observer_hud.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/touch/touch_uma.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_uma.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/utility/partial_screenshot_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/app_list_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_native_cursor_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/coordinate_conversion.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/default_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_details.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_window_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_window_resizer.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/gestures/long_press_affordance_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/gestures/overview_gesture_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/immersive_fullscreen_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/lock_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_window_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/scoped_transform_overview_window.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_grid.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_item.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/screen_dimmer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/video_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/video_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_positioner.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_properties.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_resizer.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/wm_event.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/magnetism_matcher.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/phantom_window_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/two_step_edge_cycler.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/activity/activity_frame_view.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/content/content_proxy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fefc2f865f1735a7a84c0cf4a9f30e36e1bb8542 Cr-Commit-Position: refs/heads/master@{#309448}
6 years ago (2014-12-22 19:26:09 UTC) #1
Avi (use Gerrit)
Committed patchset #1 (id:1) manually as fefc2f865f1735a7a84c0cf4a9f30e36e1bb8542 (presubmit successful).
6 years ago (2014-12-22 19:26:15 UTC) #2
tfarina
Avi, please, hold off on this. I'm working on it already for crbug.com/395370
6 years ago (2014-12-22 19:35:43 UTC) #4
Avi (use Gerrit)
Oh, I didn't know. I landed this, and have three other CLs to complete the ...
6 years ago (2014-12-22 19:37:54 UTC) #5
tfarina
On Mon, Dec 22, 2014 at 5:37 PM, Avi Drissman <avi@chromium.org> wrote: > Oh, I ...
6 years ago (2014-12-22 19:41:07 UTC) #6
Avi (use Gerrit)
6 years ago (2014-12-22 19:42:28 UTC) #7
Message was sent while issue was closed.
Go ahead. I do cleanups at the end of the year, and didn't realize that
you'd started. Sorry for stepping on your toes.

On Mon, Dec 22, 2014 at 2:41 PM, Thiago Farina <tfarina@chromium.org> wrote:

>
>
> On Mon, Dec 22, 2014 at 5:37 PM, Avi Drissman <avi@chromium.org> wrote:
>
>> Oh, I didn't know. I landed this, and have three other CLs to complete
>> the set.
>>
>> Oh Gosh!
> Can you let me finish it if you haven't submitted the others already?
>
>
>
>> On Mon, Dec 22, 2014 at 2:35 PM, <tfarina@chromium.org> wrote:
>>
>>> Avi, please, hold off on this.
>>>
>>> I'm working on it already for crbug.com/395370
>>>
>>> https://codereview.chromium.org/802473003/
>>>
>>
>>
>
>
> --
> Thiago Farina
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698