Revert "Revert of Extract WebGraphicsContext3DImpl from webkit/common/gpu. (patchset #12 id:220001 …

Reland "Extract WebGraphicsContext3DImpl from webkit/common/gpu."

This reverts commit c838415edd21dbae71740277487c733898a62ea0.

BUG=338338
R=jamesr@chromium.org,piman@chromium.org

[tfarina, 2014-12-13 20:29:45]

tfarina@chromium.org changed reviewers:
+ kjellander@webrtc.org

[tfarina, 2014-12-13 20:29:46]

James, Antoine, this is the reland. Patch set 1 is the revert of
https://crrev.com/c838415edd21dbae71740277487c733898a62ea0

+Henrik for WebRTC failures in Win8. I have no idea how they could be related to
my patch.

If it is related, maybe Henrik can have a suggestion of how to fix it?

PTAL

[tfarina, 2014-12-14 01:30:29]

tfarina@chromium.org changed reviewers:
+ kjellander@chromium.org
- kjellander@webrtc.org

[piman, 2014-12-15 19:02:39]

lgtm

[tfarina, 2014-12-16 01:43:47]

I have uploaded a CL to hopefully fix the WebRTC failure. See ->
https://webrtc-codereview.appspot.com/37409004

[kjellander_chromium, 2014-12-16 08:35:08]

lgtm if https://codereview.chromium.org/802113002/ makes the win8 trybots go
green. 

FYI I'm going to try to get WebRTC in shape for GN on Mac and Windows this week.

[kjellander_chromium, 2014-12-16 08:36:25]

On 2014/12/16 08:35:08, kjellander wrote:
> lgtm if https://codereview.chromium.org/802113002/ makes the win8 trybots go
> green. 

Doh, I meant to paste tfarina's CL:
https://webrtc-codereview.appspot.com/37409004

> 
> FYI I'm going to try to get WebRTC in shape for GN on Mac and Windows this
week.

[tfarina, 2014-12-18 04:54:01]

tfarina@chromium.org changed reviewers:
+ scottmg@chromium.org

[tfarina, 2014-12-18 04:54:02]

Scott, could you give me a light/help here?

There are now tons of erros, coming from gl.h from win8sdk.

I don't know why my patch is triggering that (those random erros on gn bot).
Isn't Win8 GN a tree closer?

[scottmg, 2014-12-18 05:06:48]

I don't know without trying it, but there's two gl.h's, one in the Windows
SDK, and another in Mesa, so there's some strange things done to make sure
we get the right ones.

Maybe the include directories, or order the include directories are
specified got changed?

On Wed, Dec 17, 2014 at 8:54 PM, <tfarina@chromium.org> wrote:
>
> Scott, could you give me a light/help here?
>
> There are now tons of erros, coming from gl.h from win8sdk.
>
> I don't know why my patch is triggering that (those random erros on gn
> bot).
> Isn't Win8 GN a tree closer?
>
>
> https://codereview.chromium.org/802113002/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2014-12-19 04:49:46]

I redo this in https://codereview.chromium.org/810273004/ with minimal changes.

Win8 GN seems to be green there. Thanks God!

Moving the review over there.

[tfarina, 2014-12-31 19:43:49]

Closing this.

Landed in
https://chromium.googlesource.com/chromium/src/+/13f5f5e58cf2b2bf9a5ad9918a37...