Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 810273004: GPU/BLINK - WIP - TAKE 2 (Closed)

Created:
6 years ago by tfarina
Modified:
5 years, 11 months ago
Reviewers:
jamesr, Torne, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, jochen (gone - plz use gerrit), abarth-chromium, pilgrim_google, Avi (use Gerrit), darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland the patch to move WebGraphicsContext3DImpl out of webkit/. BUG=338338 TEST= R=jamesr@chromium.org,piman@chromium.org TBR=torne@chromium.org Committed: https://crrev.com/13f5f5e58cf2b2bf9a5ad9918a37294d38bb2c4c Cr-Commit-Position: refs/heads/master@{#309341}

Patch Set 1 #

Patch Set 2 : more changes #

Patch Set 3 : add gyp file #

Patch Set 4 : android_webview changes #

Patch Set 5 : fix typo #

Patch Set 6 : more gyp changes #

Patch Set 7 : android_webview fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -56 lines) Patch
M android_webview/android_webview.gyp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A + gpu/blink/BUILD.gn View 1 2 2 chunks +10 lines, -16 lines 0 comments Download
A + gpu/blink/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + gpu/blink/gpu_blink.gyp View 1 2 2 chunks +5 lines, -15 lines 0 comments Download
A gpu/blink/gpu_blink_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
A + gpu/blink/webgraphicscontext3d_impl.h View 1 2 3 4 3 chunks +7 lines, -9 lines 0 comments Download
A + gpu/blink/webgraphicscontext3d_impl.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M webkit/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/gpu/BUILD.gn View 1 2 chunks +1 line, -2 lines 0 comments Download
M webkit/common/gpu/grcontext_for_webgraphicscontext3d.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M webkit/common/gpu/grcontext_for_webgraphicscontext3d.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/common/gpu/webkit_gpu.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
tfarina
It seems this is fine now. Everything is *green* expect for win_chromium_x64_rel_ng, but the telemetry ...
6 years ago (2014-12-19 14:23:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810273004/120001
6 years ago (2014-12-19 23:34:00 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-19 23:34:02 UTC) #5
piman
LGTM, but can you fix the issue title?
6 years ago (2014-12-20 02:39:24 UTC) #6
tfarina
On 2014/12/20 02:39:24, piman (Very slow to review) wrote: > LGTM, but can you fix ...
6 years ago (2014-12-20 05:04:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810273004/120001
6 years ago (2014-12-20 05:05:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/31807)
6 years ago (2014-12-20 05:11:20 UTC) #11
tfarina
TBRing Richard for android_webview (please, rubber-stamp).
6 years ago (2014-12-20 05:15:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810273004/120001
6 years ago (2014-12-20 05:16:24 UTC) #15
commit-bot: I haz the power
Committed patchset #7 (id:120001)
6 years ago (2014-12-20 05:42:32 UTC) #16
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/13f5f5e58cf2b2bf9a5ad9918a37294d38bb2c4c Cr-Commit-Position: refs/heads/master@{#309341}
6 years ago (2014-12-20 05:43:17 UTC) #17
Torne
5 years, 11 months ago (2015-01-05 11:02:33 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698