Issue 801393002: PushRegistration.unregister() can fail with a NetworkError.

Issue 801393002: PushRegistration.unregister() can fail with a NetworkError. (Closed)

Created:
6 years ago by mlamouri (slow - plz ping)

Modified:
6 years ago

Reviewers:
Mike West, Michael van Ouwerkerk

CC:
blink-reviews, dglazkov+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@push_unregister

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

PushRegistration.unregister() can fail with a NetworkError. Following recent spec change: https://github.com/w3c/push-api/pull/97 BUG=440958 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187164

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -2 lines)			Patch
M	Source/modules/push_messaging/PushError.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/modules/push_messaging/PushRegistration.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	public/platform/WebPushError.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	public/platform/WebPushProvider.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 12 (4 generated)

mlamouri (slow - plz ping)

mkwst@chromium.org: Please review changes in - public/platform/

6 years ago (2014-12-15 16:04:06 UTC) #4

mlamouri (slow - plz ping)

On 2014/12/15 16:17:09, Michael van Ouwerkerk wrote: > What is your test plan for this? ...

6 years ago (2014-12-15 16:18:59 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801393002/1

6 years ago (2014-12-15 17:03:32 UTC) #11

commit-bot: I haz the power

6 years ago (2014-12-15 18:41:17 UTC) #12

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187164