public/platform/WebPushProvider.h - Issue 801393002: PushRegistration.unregister() can fail with a NetworkError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebPushProvider.h

Issue 801393002: PushRegistration.unregister() can fail with a NetworkError. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@push_unregister

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/WebPushProvider.h

diff --git a/public/platform/WebPushProvider.h b/public/platform/WebPushProvider.h

index 89698240eb10c2400dbd8dcb34f6d22f0eeca203..892910852f2746d513ffe921f66229fdfe6c13db 100644

--- a/public/platform/WebPushProvider.h

+++ b/public/platform/WebPushProvider.h

@@ -17,7 +17,7 @@ struct WebPushRegistration;

typedef WebCallbacks<WebPushRegistration, WebPushError> WebPushRegistrationCallbacks;

typedef WebCallbacks<WebPushPermissionStatus, void> WebPushPermissionStatusCallbacks;

-typedef WebCallbacks<bool, void> WebPushUnregisterCallbacks;

+typedef WebCallbacks<bool, WebPushError> WebPushUnregisterCallbacks;

class WebPushProvider {

public:

« no previous file with comments | « public/platform/WebPushError.h ('k') | no next file » | no next file with comments »