Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: Source/modules/push_messaging/PushError.cpp

Issue 801393002: PushRegistration.unregister() can fail with a NetworkError. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@push_unregister
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/modules/push_messaging/PushRegistration.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/push_messaging/PushError.h" 6 #include "modules/push_messaging/PushError.h"
7 7
8 #include "core/dom/ExceptionCode.h" 8 #include "core/dom/ExceptionCode.h"
9 #include "wtf/OwnPtr.h" 9 #include "wtf/OwnPtr.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 PassRefPtrWillBeRawPtr<DOMException> PushError::take(ScriptPromiseResolver*, Web Type* webErrorRaw) 13 PassRefPtrWillBeRawPtr<DOMException> PushError::take(ScriptPromiseResolver*, Web Type* webErrorRaw)
14 { 14 {
15 OwnPtr<WebType> webError = adoptPtr(webErrorRaw); 15 OwnPtr<WebType> webError = adoptPtr(webErrorRaw);
16 switch (webError->errorType) { 16 switch (webError->errorType) {
17 case WebPushError::ErrorTypeAbort: 17 case WebPushError::ErrorTypeAbort:
18 return DOMException::create(AbortError, webError->message); 18 return DOMException::create(AbortError, webError->message);
19 case WebPushError::ErrorTypeNetwork:
20 return DOMException::create(NetworkError, webError->message);
19 case WebPushError::ErrorTypeNotFound: 21 case WebPushError::ErrorTypeNotFound:
20 return DOMException::create(NotFoundError, webError->message); 22 return DOMException::create(NotFoundError, webError->message);
21 case WebPushError::ErrorTypeUnknown: 23 case WebPushError::ErrorTypeUnknown:
22 return DOMException::create(UnknownError); 24 return DOMException::create(UnknownError);
23 } 25 }
24 ASSERT_NOT_REACHED(); 26 ASSERT_NOT_REACHED();
25 return DOMException::create(UnknownError); 27 return DOMException::create(UnknownError);
26 } 28 }
27 29
28 void PushError::dispose(WebType* webErrorRaw) 30 void PushError::dispose(WebType* webErrorRaw)
29 { 31 {
30 delete webErrorRaw; 32 delete webErrorRaw;
31 } 33 }
32 34
33 } // namespace blink 35 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/modules/push_messaging/PushRegistration.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698