Source/modules/push_messaging/PushError.cpp - Issue 801393002: PushRegistration.unregister() can fail with a NetworkError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushError.cpp

Issue 801393002: PushRegistration.unregister() can fail with a NetworkError. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@push_unregister

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/push_messaging/PushError.cpp

diff --git a/Source/modules/push_messaging/PushError.cpp b/Source/modules/push_messaging/PushError.cpp

index 6ae5e5af4adefde7a25686d74d29a1cdf073fb6f..13f3e591085a7050e1107bd2525cb5b26f7e418a 100644

--- a/Source/modules/push_messaging/PushError.cpp

+++ b/Source/modules/push_messaging/PushError.cpp

@@ -16,6 +16,8 @@ PassRefPtrWillBeRawPtr<DOMException> PushError::take(ScriptPromiseResolver*, Web

switch (webError->errorType) {

case WebPushError::ErrorTypeAbort:

return DOMException::create(AbortError, webError->message);

+ case WebPushError::ErrorTypeNetwork:

+ return DOMException::create(NetworkError, webError->message);

case WebPushError::ErrorTypeNotFound:

return DOMException::create(NotFoundError, webError->message);

case WebPushError::ErrorTypeUnknown:

« no previous file with comments | « no previous file | Source/modules/push_messaging/PushRegistration.cpp » ('j') | no next file with comments »