Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 800863003: Kill PageSet.AddPage and its remaining usage (Closed)

Created:
6 years ago by chrishenry
Modified:
6 years ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Kill PageSet.AddPage and its remaining usage in: * tools/perf/(benchmarks|measurements)/ * content/test/gpu BUG=439512 Committed: https://crrev.com/75355849573a712b255e9f56b20cd25bb34b8880 Cr-Commit-Position: refs/heads/master@{#308424}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -29 lines) Patch
M content/test/gpu/gpu_tests/context_lost.py View 1 chunk +7 lines, -6 lines 0 comments Download
M content/test/gpu/gpu_tests/hardware_accelerated_feature.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/maps.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/screenshot_sync.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_robustness.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/page_sets/gpu_process_tests.py View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/gpu/page_sets/gpu_rasterization_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/page_sets/memory_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/page_sets/pixel_tests.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/maps.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/repaint_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/smooth_gesture_util_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/task_execution_time_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/thread_times_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_set.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
chrishenry
6 years ago (2014-12-13 20:23:57 UTC) #3
Ken Russell (switch to Gerrit)
lgtm
6 years ago (2014-12-15 19:25:11 UTC) #4
nednguyen
lgtm
6 years ago (2014-12-15 19:28:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800863003/20001
6 years ago (2014-12-15 19:29:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years ago (2014-12-15 21:33:27 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-15 21:34:56 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/75355849573a712b255e9f56b20cd25bb34b8880
Cr-Commit-Position: refs/heads/master@{#308424}

Powered by Google App Engine
This is Rietveld 408576698