content/test/gpu/gpu_tests/maps.py - Issue 800863003: Kill PageSet.AddPage and its remaining usage

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/gpu/gpu_tests/maps.py

Issue 800863003: Kill PageSet.AddPage and its remaining usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/test/gpu/gpu_tests/hardware_accelerated_feature.py ('k') | content/test/gpu/gpu_tests/screenshot_sync.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Runs a Google Maps pixel test.	5 """Runs a Google Maps pixel test.

6 Performs several common navigation actions on the map (pan, zoom, rotate) then	6 Performs several common navigation actions on the map (pan, zoom, rotate) then

7 captures a screenshot and compares selected pixels against expected values"""	7 captures a screenshot and compares selected pixels against expected values"""

8	8

9 import json	9 import json

10 import optparse	10 import optparse

(...skipping 82 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
93 def CreateExpectations(self):	93 def CreateExpectations(self):

94 return maps_expectations.MapsExpectations()	94 return maps_expectations.MapsExpectations()

95	95

96 def CreatePageSet(self, options):	96 def CreatePageSet(self, options):

97 page_set_path = os.path.join(	97 page_set_path = os.path.join(

98 util.GetChromiumSrcDir(), 'content', 'test', 'gpu', 'page_sets')	98 util.GetChromiumSrcDir(), 'content', 'test', 'gpu', 'page_sets')

99 ps = page_set.PageSet(archive_data_file='data/maps.json',	99 ps = page_set.PageSet(archive_data_file='data/maps.json',

100 make_javascript_deterministic=False,	100 make_javascript_deterministic=False,

101 file_path=page_set_path,	101 file_path=page_set_path,

102 bucket=page_set.PUBLIC_BUCKET)	102 bucket=page_set.PUBLIC_BUCKET)

103 ps.AddPage(MapsPage(ps, ps.base_dir))	103 ps.AddUserStory(MapsPage(ps, ps.base_dir))

104 return ps	104 return ps

OLD	NEW