tools/perf/measurements/smoothness_unittest.py - Issue 800863003: Kill PageSet.AddPage and its remaining usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/smoothness_unittest.py

Issue 800863003: Kill PageSet.AddPage and its remaining usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/smoothness_unittest.py

diff --git a/tools/perf/measurements/smoothness_unittest.py b/tools/perf/measurements/smoothness_unittest.py

index 572b1c2fcaf2cbf2ea5bc0a623298acb1f3498af..ab2e26220dd4cd17b0e8c99ef34d52850a42da8b 100644

--- a/tools/perf/measurements/smoothness_unittest.py

+++ b/tools/perf/measurements/smoothness_unittest.py

@@ -131,7 +131,7 @@ class SmoothnessUnitTest(page_test_test_case.PageTestTestCase):

@test.Disabled('mac', 'chromeos') # http://crbug.com/403903

def testSmoothnessForPageWithNoGesture(self):

ps = self.CreateEmptyPageSet()

- ps.AddPage(AnimatedPage(ps))

+ ps.AddUserStory(AnimatedPage(ps))

measurement = smoothness.Smoothness()

results = self.RunMeasurement(measurement, ps, options=self._options)

@@ -164,7 +164,7 @@ class SmoothnessUnitTest(page_test_test_case.PageTestTestCase):

self.stop_called = True

ps = self.CreateEmptyPageSet()

- ps.AddPage(FailPage(ps))

+ ps.AddUserStory(FailPage(ps))

class BuggyMeasurement(smoothness.Smoothness):

fake_power = None