tools/perf/measurements/thread_times_unittest.py - Issue 800863003: Kill PageSet.AddPage and its remaining usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/thread_times_unittest.py

Issue 800863003: Kill PageSet.AddPage and its remaining usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/thread_times_unittest.py

diff --git a/tools/perf/measurements/thread_times_unittest.py b/tools/perf/measurements/thread_times_unittest.py

index 44d7bd33221f3a10b36d2e1314dfac9653a4a0ae..df31a72abeaba9859bc21e2f48bf34b362923c1a 100644

--- a/tools/perf/measurements/thread_times_unittest.py

+++ b/tools/perf/measurements/thread_times_unittest.py

@@ -32,7 +32,7 @@ class ThreadTimesUnitTest(page_test_test_case.PageTestTestCase):

def testBasicForPageWithNoGesture(self):

ps = self.CreateEmptyPageSet()

- ps.AddPage(smoothness_unittest.AnimatedPage(ps))

+ ps.AddUserStory(smoothness_unittest.AnimatedPage(ps))

measurement = thread_times.ThreadTimes()

timeline_options = self._options