Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 799733002: Use event init dictionaries in core/{css,html} (Closed)

Created:
6 years ago by bashi
Modified:
6 years ago
Reviewers:
haraken
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, blink-reviews-html_chromium.org, arv+blink, feature-media-reviews_chromium.org, blink-reviews-css, philipj_slow, eae+blinkwatch, ed+blinkwatch_opera.com, eric.carlson_apple.com, blink-reviews-events_chromium.org, dglazkov+blink, Rik, apavlov+blink_chromium.org, Inactive, darktears, aandrey+blink_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use event init dictionaries in core/{css,html} This CL replaces following EventInits with IDL dictionaries: - WebGLContextEventInit - MediaKeyEventInit - MediaQueryListEventInit Tests under fast/events/constructors cover this change. BUG=433179 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187010

Patch Set 1 : #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -101 lines) Patch
M LayoutTests/fast/events/constructors/media-key-event-constructor-expected.txt View 2 chunks +21 lines, -21 lines 0 comments Download
A LayoutTests/fast/events/constructors/media-query-list-event-constructor.html View 1 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/constructors/media-query-list-event-constructor-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/constructors/webgl-context-event-constructor.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/constructors/webgl-context-event-constructor-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 3 chunks +9 lines, -0 lines 0 comments Download
M Source/core/css/MediaQueryListEvent.h View 1 2 chunks +8 lines, -9 lines 0 comments Download
M Source/core/css/MediaQueryListEvent.idl View 1 chunk +3 lines, -3 lines 0 comments Download
A Source/core/css/MediaQueryListEventInit.idl View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/html/MediaKeyEvent.h View 1 chunk +1 line, -12 lines 0 comments Download
M Source/core/html/MediaKeyEvent.cpp View 1 chunk +15 lines, -12 lines 0 comments Download
M Source/core/html/MediaKeyEvent.idl View 1 chunk +8 lines, -8 lines 0 comments Download
A Source/core/html/MediaKeyEventInit.idl View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLContextEvent.h View 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/html/canvas/WebGLContextEvent.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/html/canvas/WebGLContextEvent.idl View 1 chunk +4 lines, -2 lines 0 comments Download
A Source/core/html/canvas/WebGLContextEventInit.idl View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp View 4 chunks +11 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bashi
Haraken-san, PTAL? https://codereview.chromium.org/799733002/diff/20001/LayoutTests/fast/events/constructors/media-key-event-constructor-expected.txt File LayoutTests/fast/events/constructors/media-key-event-constructor-expected.txt (right): https://codereview.chromium.org/799733002/diff/20001/LayoutTests/fast/events/constructors/media-key-event-constructor-expected.txt#newcode30 LayoutTests/fast/events/constructors/media-key-event-constructor-expected.txt:30: PASS new MediaKeyEvent('MediaKeyEvent', { bubbles: true, cancelable: ...
6 years ago (2014-12-12 02:05:08 UTC) #3
haraken
LGTM https://codereview.chromium.org/799733002/diff/20001/LayoutTests/fast/events/constructors/media-query-list-event-constructor.html File LayoutTests/fast/events/constructors/media-query-list-event-constructor.html (right): https://codereview.chromium.org/799733002/diff/20001/LayoutTests/fast/events/constructors/media-query-list-event-constructor.html#newcode12 LayoutTests/fast/events/constructors/media-query-list-event-constructor.html:12: shouldBe("new MediaQueryListEvent('eventType').bubbles", "false"); Nit: You can use shouldBeFalse ...
6 years ago (2014-12-12 05:12:07 UTC) #4
bashi
Thanks! https://codereview.chromium.org/799733002/diff/20001/LayoutTests/fast/events/constructors/media-query-list-event-constructor.html File LayoutTests/fast/events/constructors/media-query-list-event-constructor.html (right): https://codereview.chromium.org/799733002/diff/20001/LayoutTests/fast/events/constructors/media-query-list-event-constructor.html#newcode12 LayoutTests/fast/events/constructors/media-query-list-event-constructor.html:12: shouldBe("new MediaQueryListEvent('eventType').bubbles", "false"); On 2014/12/12 05:12:07, haraken wrote: ...
6 years ago (2014-12-12 08:58:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799733002/40001
6 years ago (2014-12-12 08:59:11 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-12 10:19:52 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187010

Powered by Google App Engine
This is Rietveld 408576698