Issue 798233005: Merge 185069 "Enforce context refrence guards in WebGL extensions."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 798233005: Merge 185069 "Enforce context refrence guards in WebGL extensions." (Closed)

Created:
6 years ago by bajones

Modified:
6 years ago

Reviewers:
bajones

CC:
blink-reviews, aandrey+blink_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik

Base URL:
svn://svn.chromium.org/blink/branches/chromium/2214/

Project:
blink

Visibility:
Public.

More Reviews

Description

Merge 185069 "Enforce context refrence guards in WebGL extensions." > Enforce context refrence guards in WebGL extensions. > > It appears that in some cases if an extension object outlives the context it was > created with that context could be GCed out from under it mid-function. This new > pattern enforces a scoped ref count of the associated canvas any time the > context is used by an extension. > > BUG=429478 > > Review URL: https://codereview.chromium.org/687533005 TBR=bajones@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187499

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -45 lines)			Patch
M	Source/core/html/canvas/ANGLEInstancedArrays.cpp	View	1 chunk	+9 lines, -6 lines	0 comments	Download
M	Source/core/html/canvas/OESVertexArrayObject.cpp	View	1 chunk	+20 lines, -16 lines	0 comments	Download
M	Source/core/html/canvas/WebGLDebugShaders.cpp	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	Source/core/html/canvas/WebGLDrawBuffers.cpp	View	1 chunk	+11 lines, -10 lines	0 comments	Download
M	Source/core/html/canvas/WebGLExtension.h	View	4 chunks	+21 lines, -6 lines	0 comments	Download
M	Source/core/html/canvas/WebGLExtension.cpp	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	Source/core/html/canvas/WebGLLoseContext.cpp	View	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r187499.

Expand Messages | Collapse Messages