Issue 7980021: Speed up x86-64 validator by inlining heavily called routines. Speeds up

Issue 7980021: Speed up x86-64 validator by inlining heavily called routines. Speeds up (Closed)

Created:
9 years, 3 months ago by Karl

Modified:
9 years, 3 months ago

Reviewers:
Brad Chen

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

Description

Speed up x86-64 validator by inlining heavily called routines. Speeds up the validator by about 10%. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2228&; Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=6743

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+475 lines, -214 lines)			Patch
M	src/trusted/validator/x86/decoder/nc_inst_iter.c	View	1	3 chunks	+10 lines, -44 lines	0 comments	Download
A	src/trusted/validator/x86/decoder/nc_inst_iter_inl.c	View	1 2	1 chunk	+101 lines, -0 lines	0 comments	Download
M	src/trusted/validator/x86/decoder/nc_inst_state_statics.c	View	1	8 chunks	+15 lines, -12 lines	0 comments	Download
M	src/trusted/validator/x86/decoder/nc_inst_trans.c	View	1	17 chunks	+37 lines, -31 lines	0 comments	Download
M	src/trusted/validator/x86/decoder/ncop_exps.c	View	1	7 chunks	+17 lines, -7 lines	0 comments	Download
A	src/trusted/validator/x86/decoder/ncop_exps_inl.c	View	1 2	1 chunk	+26 lines, -0 lines	0 comments	Download
M	src/trusted/validator/x86/decoder/ncopcode_desc.c	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
A	src/trusted/validator/x86/decoder/ncopcode_desc_inl.c	View	1 2	1 chunk	+43 lines, -0 lines	0 comments	Download
M	src/trusted/validator/x86/decoder/ncopcode_desc_verbose.c	View	1	3 chunks	+11 lines, -1 line	0 comments	Download
M	src/trusted/validator/x86/ncval_reg_sfi/address_sets.c	View	1	2 chunks	+2 lines, -45 lines	0 comments	Download
A	src/trusted/validator/x86/ncval_reg_sfi/address_sets_inl.c	View	1 2	1 chunk	+72 lines, -0 lines	0 comments	Download
M	src/trusted/validator/x86/ncval_reg_sfi/nc_cpu_checks.c	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/trusted/validator/x86/ncval_reg_sfi/nc_jumps.c	View	1	12 chunks	+17 lines, -15 lines	0 comments	Download
M	src/trusted/validator/x86/ncval_reg_sfi/nc_jumps_detailed.c	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/trusted/validator/x86/ncval_reg_sfi/nc_memory_protect.c	View	1	6 chunks	+10 lines, -9 lines	0 comments	Download
M	src/trusted/validator/x86/ncval_reg_sfi/nc_protect_base.c	View	1	8 chunks	+14 lines, -12 lines	0 comments	Download
M	src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.c	View	1	6 chunks	+13 lines, -12 lines	0 comments	Download
M	src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_utils.c	View	1	8 chunks	+13 lines, -11 lines	0 comments	Download
M	src/trusted/validator/x86/ncval_reg_sfi/ncvalidator_registry.c	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/trusted/validator/x86/x86_insts.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/trusted/validator/x86/x86_insts.c	View	1	2 chunks	+17 lines, -4 lines	0 comments	Download
A	src/trusted/validator/x86/x86_insts_inl.c	View	1 2	1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brad Chen

9 years, 3 months ago (2011-09-20 22:29:30 UTC) #2

LGTM

http://codereview.chromium.org/7980021/diff/1/src/trusted/validator/x86/decod...
File src/trusted/validator/x86/decoder/nc_inst_iter_inl.h (right):

http://codereview.chromium.org/7980021/diff/1/src/trusted/validator/x86/decod...
src/trusted/validator/x86/decoder/nc_inst_iter_inl.h:21: #define
NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_DECODER_NC_INST_ITER_INL_h_
capital 'h'? Also, why are you using a .h file instead of a .c file? Consistency
would be good.

Expand Messages | Collapse Messages