Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: src/trusted/validator/x86/ncval_reg_sfi/ncvalidator_registry.c

Issue 7980021: Speed up x86-64 validator by inlining heavily called routines. Speeds up (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_utils.c ('k') | src/trusted/validator/x86/x86_insts.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator/x86/ncval_reg_sfi/ncvalidator_registry.c
===================================================================
--- src/trusted/validator/x86/ncval_reg_sfi/ncvalidator_registry.c (revision 6742)
+++ src/trusted/validator/x86/ncval_reg_sfi/ncvalidator_registry.c (working copy)
@@ -7,7 +7,6 @@
#include "native_client/src/trusted/validator/x86/ncval_reg_sfi/ncvalidator_registry.h"
#include "native_client/src/shared/platform/nacl_log.h"
-#include "native_client/src/trusted/validator/x86/decoder/nc_inst_iter.h"
#include "native_client/src/trusted/validator/x86/decoder/nc_inst_state.h"
#include "native_client/src/trusted/validator/x86/decoder/ncop_exps.h"
#include "native_client/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.h"
@@ -20,13 +19,15 @@
#include "native_client/src/trusted/validator/x86/ncval_reg_sfi/nc_memory_protect.h"
#include "native_client/src/trusted/validator/x86/ncval_reg_sfi/nc_protect_base.h"
+#include "native_client/src/trusted/validator/x86/decoder/nc_inst_iter_inl.c"
+
Bool NACL_FLAGS_opcode_histogram = FALSE;
static void NaClValidatorTrace(NaClValidatorState* state,
NaClInstIter* iter,
void* local_memory) {
struct Gio* g = NaClLogGetGio();
- NaClInstState* inst_state = NaClInstIterGetState(iter);
+ NaClInstState* inst_state = NaClInstIterGetStateInline(iter);
if (NaClValidatorStateTrace(state)) {
gprintf(g, "-> visit: ");
}
« no previous file with comments | « src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_utils.c ('k') | src/trusted/validator/x86/x86_insts.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698