Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 797943002: Consistently use only one of virtual/OVERRIDE/FINAL. (Closed)

Created:
6 years ago by Sven Panne
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Consistently use only one of virtual/OVERRIDE/FINAL. FINAL implies OVERRIDE, which in turn implies virtual, so there's no need to use more than one of these. The Google C++ style guide even requires this, see http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Inheritance. While we're here, port r24662 to x87. The net result is that v8 compiles again with a current clang. BUG=v8:3753 LOG=y

Patch Set 1 #

Patch Set 2 : Removed temporary hack. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1665 lines, -1990 lines) Patch
M build/standalone.gypi View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm/code-stubs-arm.h View 5 chunks +6 lines, -6 lines 0 comments Download
M src/arm/lithium-arm.h View 44 chunks +65 lines, -81 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 13 chunks +37 lines, -36 lines 0 comments Download
M src/arm64/code-stubs-arm64.h View 5 chunks +6 lines, -6 lines 0 comments Download
M src/arm64/lithium-arm64.h View 42 chunks +66 lines, -82 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ast.h View 49 chunks +164 lines, -202 lines 0 comments Download
M src/ast-this-access-visitor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast-value-factory.h View 2 chunks +4 lines, -6 lines 0 comments Download
M src/ast-value-factory.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/base/platform/time.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M src/bootstrapper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 56 chunks +118 lines, -148 lines 0 comments Download
M src/compiler.cc View 1 chunk +15 lines, -15 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 5 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/change-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-context-specialization.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/machine-operator-reducer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/operator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/value-numbering-reducer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/d8.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M src/elements.cc View 16 chunks +28 lines, -59 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 7 chunks +8 lines, -8 lines 0 comments Download
M src/hydrogen-instructions.h View 231 chunks +424 lines, -492 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 13 chunks +37 lines, -36 lines 0 comments Download
M src/ia32/lithium-ia32.h View 42 chunks +66 lines, -84 lines 0 comments Download
M src/ic/ic.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/libplatform/default-platform.h View 1 chunk +1 line, -1 line 0 comments Download
M src/libplatform/worker-thread.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.h View 5 chunks +6 lines, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 13 chunks +37 lines, -36 lines 0 comments Download
M src/mips/lithium-mips.h View 44 chunks +65 lines, -81 lines 0 comments Download
M src/mips64/code-stubs-mips64.h View 5 chunks +6 lines, -6 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 12 chunks +34 lines, -34 lines 0 comments Download
M src/mips64/lithium-mips64.h View 44 chunks +65 lines, -81 lines 0 comments Download
M src/objects.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/objects-inl.h View 8 chunks +14 lines, -14 lines 0 comments Download
M src/optimizing-compiler-thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ostreams.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 13 chunks +26 lines, -32 lines 0 comments Download
M src/ppc/lithium-ppc.h View 42 chunks +62 lines, -72 lines 0 comments Download
M src/prettyprinter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/scanner-character-streams.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/serialize.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/serialize.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/string-stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/type-feedback-vector.h View 3 chunks +10 lines, -10 lines 0 comments Download
M src/x64/code-stubs-x64.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 13 chunks +37 lines, -36 lines 0 comments Download
M src/x64/lithium-x64.h View 43 chunks +66 lines, -85 lines 0 comments Download
M src/x87/code-stubs-x87.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 13 chunks +37 lines, -36 lines 0 comments Download
M src/x87/lithium-x87.h View 43 chunks +67 lines, -87 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sven Panne
6 years ago (2014-12-12 09:34:34 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-12 10:10:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797943002/20001
6 years ago (2014-12-12 10:15:35 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-12 10:44:22 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698