Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: build/standalone.gypi

Issue 797943002: Consistently use only one of virtual/OVERRIDE/FINAL. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removed temporary hack. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm/code-stubs-arm.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 ], 231 ],
232 'ldflags': [ 232 'ldflags': [
233 '-fsanitize=thread', 233 '-fsanitize=thread',
234 '-pie', 234 '-pie',
235 ], 235 ],
236 'defines': [ 236 'defines': [
237 'THREAD_SANITIZER', 237 'THREAD_SANITIZER',
238 ], 238 ],
239 }, 239 },
240 }], 240 }],
241 ['clang==1', {
242 'target_defaults': {
243 # Remove once issue 3753 is fixed.
244 'cflags_cc': [ '-Wno-inconsistent-missing-override',
245 '-Wno-unknown-warning-option', ],
246 },
247 }],
248 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \ 241 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
249 or OS=="netbsd"', { 242 or OS=="netbsd"', {
250 'target_defaults': { 243 'target_defaults': {
251 'cflags': [ 244 'cflags': [
252 '-Wall', 245 '-Wall',
253 '<(werror)', 246 '<(werror)',
254 '-W', 247 '-W',
255 '-Wno-unused-parameter', 248 '-Wno-unused-parameter',
256 '-Wno-long-long', 249 '-Wno-long-long',
257 '-pthread', 250 '-pthread',
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 ], 450 ],
458 }], 451 }],
459 ['clang==1 and OS=="win"', { 452 ['clang==1 and OS=="win"', {
460 'make_global_settings': [ 453 'make_global_settings': [
461 # On Windows, gyp's ninja generator only looks at CC. 454 # On Windows, gyp's ninja generator only looks at CC.
462 ['CC', '<(make_clang_dir)/bin/clang-cl'], 455 ['CC', '<(make_clang_dir)/bin/clang-cl'],
463 ], 456 ],
464 }], 457 }],
465 ], 458 ],
466 } 459 }
OLDNEW
« no previous file with comments | « no previous file | src/arm/code-stubs-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698