Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Side by Side Diff: src/compiler.cc

Issue 797943002: Consistently use only one of virtual/OVERRIDE/FINAL. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removed temporary hack. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stubs.h ('k') | src/compiler/ast-graph-builder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/compiler.h" 7 #include "src/compiler.h"
8 8
9 #include "src/ast-numbering.h" 9 #include "src/ast-numbering.h"
10 #include "src/ast-this-access-visitor.h" 10 #include "src/ast-this-access-visitor.h"
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 } 303 }
304 } 304 }
305 305
306 306
307 class HOptimizedGraphBuilderWithPositions: public HOptimizedGraphBuilder { 307 class HOptimizedGraphBuilderWithPositions: public HOptimizedGraphBuilder {
308 public: 308 public:
309 explicit HOptimizedGraphBuilderWithPositions(CompilationInfo* info) 309 explicit HOptimizedGraphBuilderWithPositions(CompilationInfo* info)
310 : HOptimizedGraphBuilder(info) { 310 : HOptimizedGraphBuilder(info) {
311 } 311 }
312 312
313 #define DEF_VISIT(type) \ 313 #define DEF_VISIT(type) \
314 virtual void Visit##type(type* node) OVERRIDE { \ 314 void Visit##type(type* node) OVERRIDE { \
315 if (node->position() != RelocInfo::kNoPosition) { \ 315 if (node->position() != RelocInfo::kNoPosition) { \
316 SetSourcePosition(node->position()); \ 316 SetSourcePosition(node->position()); \
317 } \ 317 } \
318 HOptimizedGraphBuilder::Visit##type(node); \ 318 HOptimizedGraphBuilder::Visit##type(node); \
319 } 319 }
320 EXPRESSION_NODE_LIST(DEF_VISIT) 320 EXPRESSION_NODE_LIST(DEF_VISIT)
321 #undef DEF_VISIT 321 #undef DEF_VISIT
322 322
323 #define DEF_VISIT(type) \ 323 #define DEF_VISIT(type) \
324 virtual void Visit##type(type* node) OVERRIDE { \ 324 void Visit##type(type* node) OVERRIDE { \
325 if (node->position() != RelocInfo::kNoPosition) { \ 325 if (node->position() != RelocInfo::kNoPosition) { \
326 SetSourcePosition(node->position()); \ 326 SetSourcePosition(node->position()); \
327 } \ 327 } \
328 HOptimizedGraphBuilder::Visit##type(node); \ 328 HOptimizedGraphBuilder::Visit##type(node); \
329 } 329 }
330 STATEMENT_NODE_LIST(DEF_VISIT) 330 STATEMENT_NODE_LIST(DEF_VISIT)
331 #undef DEF_VISIT 331 #undef DEF_VISIT
332 332
333 #define DEF_VISIT(type) \ 333 #define DEF_VISIT(type) \
334 virtual void Visit##type(type* node) OVERRIDE { \ 334 void Visit##type(type* node) OVERRIDE { \
335 HOptimizedGraphBuilder::Visit##type(node); \ 335 HOptimizedGraphBuilder::Visit##type(node); \
336 } 336 }
337 MODULE_NODE_LIST(DEF_VISIT) 337 MODULE_NODE_LIST(DEF_VISIT)
338 DECLARATION_NODE_LIST(DEF_VISIT) 338 DECLARATION_NODE_LIST(DEF_VISIT)
339 #undef DEF_VISIT 339 #undef DEF_VISIT
340 }; 340 };
341 341
342 342
343 OptimizedCompileJob::Status OptimizedCompileJob::CreateGraph() { 343 OptimizedCompileJob::Status OptimizedCompileJob::CreateGraph() {
344 DCHECK(info()->IsOptimizing()); 344 DCHECK(info()->IsOptimizing());
345 DCHECK(!info()->IsCompilingForDebugging()); 345 DCHECK(!info()->IsCompilingForDebugging());
(...skipping 1226 matching lines...) Expand 10 before | Expand all | Expand 10 after
1572 AllowHandleDereference allow_deref; 1572 AllowHandleDereference allow_deref;
1573 bool tracing_on = info()->IsStub() 1573 bool tracing_on = info()->IsStub()
1574 ? FLAG_trace_hydrogen_stubs 1574 ? FLAG_trace_hydrogen_stubs
1575 : (FLAG_trace_hydrogen && 1575 : (FLAG_trace_hydrogen &&
1576 info()->closure()->PassesFilter(FLAG_trace_hydrogen_filter)); 1576 info()->closure()->PassesFilter(FLAG_trace_hydrogen_filter));
1577 return (tracing_on && 1577 return (tracing_on &&
1578 base::OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL); 1578 base::OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL);
1579 } 1579 }
1580 1580
1581 } } // namespace v8::internal 1581 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/code-stubs.h ('k') | src/compiler/ast-graph-builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698