Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/ast-value-factory.cc

Issue 797943002: Consistently use only one of virtual/OVERRIDE/FINAL. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removed temporary hack. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast-value-factory.h ('k') | src/base/platform/time.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 int pos_; 49 int pos_;
50 }; 50 };
51 51
52 } 52 }
53 53
54 class AstRawStringInternalizationKey : public HashTableKey { 54 class AstRawStringInternalizationKey : public HashTableKey {
55 public: 55 public:
56 explicit AstRawStringInternalizationKey(const AstRawString* string) 56 explicit AstRawStringInternalizationKey(const AstRawString* string)
57 : string_(string) {} 57 : string_(string) {}
58 58
59 virtual bool IsMatch(Object* other) OVERRIDE { 59 bool IsMatch(Object* other) OVERRIDE {
60 if (string_->is_one_byte_) 60 if (string_->is_one_byte_)
61 return String::cast(other)->IsOneByteEqualTo(string_->literal_bytes_); 61 return String::cast(other)->IsOneByteEqualTo(string_->literal_bytes_);
62 return String::cast(other)->IsTwoByteEqualTo( 62 return String::cast(other)->IsTwoByteEqualTo(
63 Vector<const uint16_t>::cast(string_->literal_bytes_)); 63 Vector<const uint16_t>::cast(string_->literal_bytes_));
64 } 64 }
65 65
66 virtual uint32_t Hash() OVERRIDE { 66 uint32_t Hash() OVERRIDE { return string_->hash() >> Name::kHashShift; }
67 return string_->hash() >> Name::kHashShift;
68 }
69 67
70 virtual uint32_t HashForObject(Object* key) OVERRIDE { 68 uint32_t HashForObject(Object* key) OVERRIDE {
71 return String::cast(key)->Hash(); 69 return String::cast(key)->Hash();
72 } 70 }
73 71
74 virtual Handle<Object> AsHandle(Isolate* isolate) OVERRIDE { 72 Handle<Object> AsHandle(Isolate* isolate) OVERRIDE {
75 if (string_->is_one_byte_) 73 if (string_->is_one_byte_)
76 return isolate->factory()->NewOneByteInternalizedString( 74 return isolate->factory()->NewOneByteInternalizedString(
77 string_->literal_bytes_, string_->hash()); 75 string_->literal_bytes_, string_->hash());
78 return isolate->factory()->NewTwoByteInternalizedString( 76 return isolate->factory()->NewTwoByteInternalizedString(
79 Vector<const uint16_t>::cast(string_->literal_bytes_), string_->hash()); 77 Vector<const uint16_t>::cast(string_->literal_bytes_), string_->hash());
80 } 78 }
81 79
82 private: 80 private:
83 const AstRawString* string_; 81 const AstRawString* string_;
84 }; 82 };
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 if (isolate_) { 376 if (isolate_) {
379 new_string->Internalize(isolate_); 377 new_string->Internalize(isolate_);
380 } 378 }
381 entry->value = reinterpret_cast<void*>(1); 379 entry->value = reinterpret_cast<void*>(1);
382 } 380 }
383 return reinterpret_cast<AstRawString*>(entry->key); 381 return reinterpret_cast<AstRawString*>(entry->key);
384 } 382 }
385 383
386 384
387 } } // namespace v8::internal 385 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast-value-factory.h ('k') | src/base/platform/time.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698