Replicate sandbox flags for OOPIF (Chromium part 2)

Replicate sandbox flags for OOPIF (Chromium part 2).

* Remove old versions of createChildFrame.
* Add browser tests.

Related CLs:
Chromium part 1: https://codereview.chromium.org/837283003/
Blink part 1: https://codereview.chromium.org/793493003/
Blink part 2: https://codereview.chromium.org/838903002/

BUG=426512
Committed: https://crrev.com/f832a2f6df39d1c9d0e0a759d21b273fee95f537
Cr-Commit-Position: refs/heads/master@{#313384}

[alexmos, 2015-01-16 18:58:55]

alexmos@chromium.org changed reviewers:
+ nasko@chromium.org

[alexmos, 2015-01-16 18:58:56]

Nasko, could you please take a look?

[nasko, 2015-01-20 23:26:50]

Just a couple of nits on the test, otherwise it looks good!

https://codereview.chromium.org/797813006/diff/80001/content/browser/site_per...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/797813006/diff/80001/content/browser/site_per...
content/browser/site_per_process_browsertest.cc:971: // subframe.
NavigateFrameToURL can't be used here because it doesn't
I think it still can be used, but cannot be the condition for the wait, as it
will return earlier. It might be useful to use it to avoid the code clutter of
calling LoadURLWithParams.

https://codereview.chromium.org/797813006/diff/80001/content/browser/site_per...
content/browser/site_per_process_browsertest.cc:1001: EXPECT_TRUE(success);
Might be useful to install an observer monitoring for new windows created on the
browser side. This way we don't rely only on blink and JS, but double check our
expectations.

[alexmos, 2015-01-21 02:10:43]

https://codereview.chromium.org/797813006/diff/80001/content/browser/site_per...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/797813006/diff/80001/content/browser/site_per...
content/browser/site_per_process_browsertest.cc:971: // subframe.
NavigateFrameToURL can't be used here because it doesn't
On 2015/01/20 23:26:49, nasko wrote:
> I think it still can be used, but cannot be the condition for the wait, as it
> will return earlier. It might be useful to use it to avoid the code clutter of
> calling LoadURLWithParams.

Done.

https://codereview.chromium.org/797813006/diff/80001/content/browser/site_per...
content/browser/site_per_process_browsertest.cc:1001: EXPECT_TRUE(success);
On 2015/01/20 23:26:49, nasko wrote:
> Might be useful to install an observer monitoring for new windows created on
the
> browser side. This way we don't rely only on blink and JS, but double check
our
> expectations.

Good point.  I added checks that Shell::windows().size() stays at 1 after each
call (see PS7), which seemed a bit simpler than installing an observer.  Would
this be sufficient?

[nasko, 2015-01-21 17:36:37]

LGTM

https://codereview.chromium.org/797813006/diff/80001/content/browser/site_per...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/797813006/diff/80001/content/browser/site_per...
content/browser/site_per_process_browsertest.cc:1001: EXPECT_TRUE(success);
On 2015/01/21 02:10:43, alexmos wrote:
> On 2015/01/20 23:26:49, nasko wrote:
> > Might be useful to install an observer monitoring for new windows created on
> the
> > browser side. This way we don't rely only on blink and JS, but double check
> our
> > expectations.
> 
> Good point.  I added checks that Shell::windows().size() stays at 1 after each
> call (see PS7), which seemed a bit simpler than installing an observer.  Would
> this be sufficient?

Yes, that is totally fine.

[alexmos, 2015-01-23 00:09:54]

alexmos@chromium.org changed reviewers:
+ aa@chromium.org, thestig@chromium.org

[alexmos, 2015-01-23 00:09:55]

Time for a couple of OWNER approvals:

thestig@: please review components/printing/renderer/print_web_view_helper.cc
aa@: please review mojo/services/html_viewer/*

[Lei Zhang, 2015-01-23 00:13:21]

On 2015/01/23 00:09:55, alexmos wrote:
> Time for a couple of OWNER approvals:
> 
> thestig@: please review components/printing/renderer/print_web_view_helper.cc

lgtm, but your trybots are all red...

[alexmos, 2015-01-23 01:01:03]

On 2015/01/23 00:13:21, Lei Zhang wrote:
> On 2015/01/23 00:09:55, alexmos wrote:
> > Time for a couple of OWNER approvals:
> > 
> > thestig@: please review
components/printing/renderer/print_web_view_helper.cc
> 
> lgtm, but your trybots are all red...

Thanks.  I ran the trybots too early - this needed a rebase and also needs
https://codereview.chromium.org/838903002/ to roll.

[alexmos, 2015-01-23 07:53:37]

alexmos@chromium.org changed reviewers:
+ mkosiba@chromium.org

[alexmos, 2015-01-23 07:53:38]

Another owner approval: 
mkosiba@: please review android_webview/renderer/print_web_view_helper.cc

[mkosiba (inactive), 2015-01-23 10:01:30]

lgtm

[alexmos, 2015-01-26 20:50:57]

aa@: friendly ping for owners approval for mojo/services/html_viewer/*

[Aaron Boodman, 2015-01-27 18:51:40]

lgtm

[alexmos, 2015-01-27 20:59:04]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2015-01-27 21:00:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/797813006/220001

[commit-bot: I haz the power, 2015-01-27 21:08:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 21:08:04]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[alexmos, 2015-01-27 22:02:33]

alexmos@chromium.org changed reviewers:
+ boliu@chromium.org

[alexmos, 2015-01-27 22:07:28]

boliu@: could you please review
android_webview/renderer/print_web_view_helper.cc for owner approval?  

mkosiba@ already signed off on it, but it seems he was just removed from OWNERS,
causing this CL to fail presubmit on the CQ.  The change is trivial, just
undoing some temporary code.

[boliu, 2015-01-27 22:28:25]

On 2015/01/27 22:07:28, alexmos wrote:
> boliu@: could you please review
> android_webview/renderer/print_web_view_helper.cc for owner approval?  
> 
> mkosiba@ already signed off on it, but it seems he was just removed from
OWNERS,
> causing this CL to fail presubmit on the CQ.  The change is trivial, just
> undoing some temporary code.

rs lgtm

[alexmos, 2015-01-27 22:37:47]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2015-01-27 22:39:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/797813006/220001

[commit-bot: I haz the power, 2015-01-27 22:44:40]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2015-01-27 22:46:26]

Patchset 12 (id:??) landed as
https://crrev.com/f832a2f6df39d1c9d0e0a759d21b273fee95f537
Cr-Commit-Position: refs/heads/master@{#313384}