Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1992)

Unified Diff: android_webview/renderer/print_web_view_helper.cc

Issue 797813006: Replicate sandbox flags for OOPIF (Chromium part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iframe-sandbox-flags-part1
Patch Set: Fix issue in previous rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/printing/renderer/print_web_view_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/renderer/print_web_view_helper.cc
diff --git a/android_webview/renderer/print_web_view_helper.cc b/android_webview/renderer/print_web_view_helper.cc
index f47916dda52a7028dd231c317cc940bd9b8425fc..a9727efbcd6847685a14a259271341d8f7a20b4d 100644
--- a/android_webview/renderer/print_web_view_helper.cc
+++ b/android_webview/renderer/print_web_view_helper.cc
@@ -541,9 +541,6 @@ class PrepareFrameAndViewForPrint : public blink::WebViewClient,
virtual void didStopLoading();
// blink::WebFrameClient override:
- // TODO(alexmos): Remove once Blink is updated to use sandbox flags.
- virtual blink::WebFrame* createChildFrame(blink::WebLocalFrame* parent,
- const blink::WebString& name);
virtual blink::WebFrame* createChildFrame(
blink::WebLocalFrame* parent,
const blink::WebString& name,
@@ -688,13 +685,6 @@ void PrepareFrameAndViewForPrint::didStopLoading() {
weak_ptr_factory_.GetWeakPtr()));
}
-// TODO(alexmos): Remove once Blink is updated to use sandbox flags.
-blink::WebFrame* PrepareFrameAndViewForPrint::createChildFrame(
- blink::WebLocalFrame* parent,
- const blink::WebString& name) {
- return createChildFrame(parent, name, blink::WebSandboxFlags::None);
-}
-
blink::WebFrame* PrepareFrameAndViewForPrint::createChildFrame(
blink::WebLocalFrame* parent,
const blink::WebString& name,
« no previous file with comments | « no previous file | components/printing/renderer/print_web_view_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698