Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 797813006: Replicate sandbox flags for OOPIF (Chromium part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iframe-sandbox-flags-part1
Patch Set: Fix issue in previous rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/printing/renderer/print_web_view_helper.cc
diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc
index dcd4305f2a1ee4927ce8b8002edb1f838fd0978d..66051ab0129ef1b797b8817006fee35f79b587e6 100644
--- a/components/printing/renderer/print_web_view_helper.cc
+++ b/components/printing/renderer/print_web_view_helper.cc
@@ -560,10 +560,6 @@ class PrepareFrameAndViewForPrint : public blink::WebViewClient,
virtual void didStopLoading();
// blink::WebFrameClient override:
- // TODO(alexmos): Remove once Blink is updated to use sandbox flags.
- virtual blink::WebFrame* createChildFrame(
- blink::WebLocalFrame* parent,
- const blink::WebString& name);
virtual blink::WebFrame* createChildFrame(
blink::WebLocalFrame* parent,
const blink::WebString& name,
@@ -710,13 +706,6 @@ void PrepareFrameAndViewForPrint::didStopLoading() {
weak_ptr_factory_.GetWeakPtr()));
}
-// TODO(alexmos): Remove once Blink is updated to use sandbox flags.
-blink::WebFrame* PrepareFrameAndViewForPrint::createChildFrame(
- blink::WebLocalFrame* parent,
- const blink::WebString& name) {
- return createChildFrame(parent, name, blink::WebSandboxFlags::None);
-}
-
blink::WebFrame* PrepareFrameAndViewForPrint::createChildFrame(
blink::WebLocalFrame* parent,
const blink::WebString& name,
« no previous file with comments | « android_webview/renderer/print_web_view_helper.cc ('k') | content/browser/frame_host/frame_tree_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698