content/renderer/render_frame_impl.h - Issue 797813006: Replicate sandbox flags for OOPIF (Chromium part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 797813006: Replicate sandbox flags for OOPIF (Chromium part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iframe-sandbox-flags-part1

Patch Set: Fix issue in previous rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 01fdce25d7b6e394fd133712907c5696ea81b998..885ca573896f878a97f4de2f135c2edc41d8859b 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -358,10 +358,6 @@ class CONTENT_EXPORT RenderFrameImpl

virtual blink::WebServiceWorkerProvider* createServiceWorkerProvider(

blink::WebLocalFrame* frame);

virtual void didAccessInitialDocument(blink::WebLocalFrame* frame);

- // TODO(alexmos): Remove once Blink is updated to use the version that takes

- // sandboxFlags.

- virtual blink::WebFrame* createChildFrame(blink::WebLocalFrame* parent,

- const blink::WebString& name);

virtual blink::WebFrame* createChildFrame(

blink::WebLocalFrame* parent,

const blink::WebString& name,

« no previous file with comments | « content/common/frame_replication_state.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »