Use the HashSet of attribute names in SharedStyleFinder.

Use the HashSet of attribute names in SharedStyleFinder.

Instead of trying to match the actual attribute rules, lets just look
at the HashSet of attribute names. This is faster, though possibly less
optimal if you use compound rules like .foo[attr]. That's rare though,
and removing this extra RuleSet will allow simplifying SelectorChecker
since hasAnyMatchingRules required a special mode where it tried to
match selectors but ignored if the scope could really match. This paves
the way to moving the RuleFeatureSet to be per-TreeScope instead of
per-Document.

I also made the API of classNamesAffectedByRules match the newly added
attributesAffectedByRules to make SharedStyleFinder consistent.

R=ojan@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/c5ef9d66e77db0097e024c8649707612917530ee

[esprehn, 2014-12-10 21:32:52]

esprehn@chromium.org changed reviewers:
+ eseidel@chromium.org, ojan@chromium.org

[ojan, 2014-12-10 23:22:58]

lgtm

https://codereview.chromium.org/796583002/diff/1/sky/engine/core/css/resolver...
File sky/engine/core/css/resolver/SharedStyleFinder.cpp (right):

https://codereview.chromium.org/796583002/diff/1/sky/engine/core/css/resolver...
sky/engine/core/css/resolver/SharedStyleFinder.cpp:66: for
(AttributeCollection::iterator it = attributes.begin(); it != end; ++it) {
Can you use C++11 iterators here? I think the syntax would be:
for (auto& attribute : element.attributesWithoutUpdate()) {

[esprehn, 2014-12-11 01:12:11]

Committed patchset #2 (id:20001) manually as
c5ef9d66e77db0097e024c8649707612917530ee (presubmit successful).