sky/engine/core/css/RuleSet.cpp - Issue 796583002: Use the HashSet of attribute names in SharedStyleFinder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/css/RuleSet.cpp

Issue 796583002: Use the HashSet of attribute names in SharedStyleFinder. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Use C++11 loops. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/css/RuleSet.cpp

diff --git a/sky/engine/core/css/RuleSet.cpp b/sky/engine/core/css/RuleSet.cpp

index a01f0599877db544634fe213325f54f5829d8ed1..53e409acf83677cec9c4556ce3130c0cb95a942e 100644

--- a/sky/engine/core/css/RuleSet.cpp

+++ b/sky/engine/core/css/RuleSet.cpp

@@ -156,7 +156,7 @@ bool RuleSet::findBestRuleSetAndAdd(const CSSSelector& component, RuleData& rule

void RuleSet::addRule(StyleRule* rule, unsigned selectorIndex, AddRuleFlags addRuleFlags)

{

RuleData ruleData(rule, selectorIndex, m_ruleCount++, addRuleFlags);

- m_features.collectFeaturesFromRuleData(ruleData);

+ m_features.collectFeaturesFromSelector(ruleData.selector());

if (!findBestRuleSetAndAdd(ruleData.selector(), ruleData)) {

// If we didn't find a specialized map to stick it in, file under universal rules.