Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: sky/engine/core/css/RuleFeature.cpp

Issue 796583002: Use the HashSet of attribute names in SharedStyleFinder. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Use C++11 loops. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/css/RuleFeature.h ('k') | sky/engine/core/css/RuleSet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/css/RuleFeature.cpp
diff --git a/sky/engine/core/css/RuleFeature.cpp b/sky/engine/core/css/RuleFeature.cpp
index 4e807a900df9e686b9ec76d8226cff44b935a13b..27f7e533a2e598732fb25318ebfd033269bbe6bc 100644
--- a/sky/engine/core/css/RuleFeature.cpp
+++ b/sky/engine/core/css/RuleFeature.cpp
@@ -57,14 +57,6 @@ void RuleFeatureSet::addSelectorFeatures(const CSSSelector& selector)
m_attributeNames.add(selector.attribute().localName());
}
-void RuleFeatureSet::collectFeaturesFromRuleData(const RuleData& ruleData)
-{
- collectFeaturesFromSelector(ruleData.selector());
-
- if (ruleData.containsAttributeSelector())
- attributeRules.append(RuleFeature(ruleData.rule(), ruleData.selectorIndex()));
-}
-
void RuleFeatureSet::collectFeaturesFromSelector(const CSSSelector& selector)
{
for (const CSSSelector* current = &selector; current; current = current->tagHistory()) {
@@ -90,13 +82,10 @@ void RuleFeatureSet::add(const RuleFeatureSet& other)
m_attributeNames.add(*it);
for (HashSet<AtomicString>::const_iterator it = other.m_idNames.begin(); it != other.m_idNames.end(); ++it)
m_idNames.add(*it);
-
- attributeRules.appendVector(other.attributeRules);
}
void RuleFeatureSet::clear()
{
- attributeRules.clear();
m_classNames.clear();
m_attributeNames.clear();
m_idNames.clear();
« no previous file with comments | « sky/engine/core/css/RuleFeature.h ('k') | sky/engine/core/css/RuleSet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698