Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: sky/engine/core/css/RuleSet.cpp

Issue 796583002: Use the HashSet of attribute names in SharedStyleFinder. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Use C++11 loops. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/css/RuleFeature.cpp ('k') | sky/engine/core/css/resolver/SharedStyleFinder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 addToRuleSet(tagName, ensurePendingRules()->tagRules, ruleData); 149 addToRuleSet(tagName, ensurePendingRules()->tagRules, ruleData);
150 return true; 150 return true;
151 } 151 }
152 152
153 return false; 153 return false;
154 } 154 }
155 155
156 void RuleSet::addRule(StyleRule* rule, unsigned selectorIndex, AddRuleFlags addR uleFlags) 156 void RuleSet::addRule(StyleRule* rule, unsigned selectorIndex, AddRuleFlags addR uleFlags)
157 { 157 {
158 RuleData ruleData(rule, selectorIndex, m_ruleCount++, addRuleFlags); 158 RuleData ruleData(rule, selectorIndex, m_ruleCount++, addRuleFlags);
159 m_features.collectFeaturesFromRuleData(ruleData); 159 m_features.collectFeaturesFromSelector(ruleData.selector());
160 160
161 if (!findBestRuleSetAndAdd(ruleData.selector(), ruleData)) { 161 if (!findBestRuleSetAndAdd(ruleData.selector(), ruleData)) {
162 // If we didn't find a specialized map to stick it in, file under univer sal rules. 162 // If we didn't find a specialized map to stick it in, file under univer sal rules.
163 m_universalRules.append(ruleData); 163 m_universalRules.append(ruleData);
164 } 164 }
165 } 165 }
166 166
167 void RuleSet::addFontFaceRule(StyleRuleFontFace* rule) 167 void RuleSet::addFontFaceRule(StyleRuleFontFace* rule)
168 { 168 {
169 ensurePendingRules(); // So that m_fontFaceRules.shrinkToFit() gets called. 169 ensurePendingRules(); // So that m_fontFaceRules.shrinkToFit() gets called.
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 248
249 #ifndef NDEBUG 249 #ifndef NDEBUG
250 void RuleSet::show() 250 void RuleSet::show()
251 { 251 {
252 for (Vector<RuleData>::const_iterator it = m_allRules.begin(); it != m_allRu les.end(); ++it) 252 for (Vector<RuleData>::const_iterator it = m_allRules.begin(); it != m_allRu les.end(); ++it)
253 it->selector().show(); 253 it->selector().show();
254 } 254 }
255 #endif 255 #endif
256 256
257 } // namespace blink 257 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/core/css/RuleFeature.cpp ('k') | sky/engine/core/css/resolver/SharedStyleFinder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698