Issue 793393003: Move the call to mojo::View::Embed to HTMLIFrameElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 793393003: Move the call to mojo::View::Embed to HTMLIFrameElement (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
eseidel

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Move the call to mojo::View::Embed to HTMLIFrameElement This CL prepares us to expose the imported and exported service providers to JavaScript. We can't quite do that yet becaues the API on mojo::View isn't ready for us. However, we can get started by moving the call to Embed into HTMLIFrameElement. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ea757c187ce91d453fed64a1bd18cfe08439cd9e

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -15 lines)			Patch
M	sky/engine/core/html/HTMLIFrameElement.cpp	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	sky/engine/core/loader/EmptyClients.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/loader/FrameLoaderClient.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/public/web/WebFrameClient.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/web/FrameLoaderClientImpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/web/FrameLoaderClientImpl.cpp	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	sky/viewer/document_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/viewer/document_view.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 11 months ago (2015-01-21 18:49:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ea757c187ce91d453fed64a1bd18cfe08439cd9e (presubmit successful).