Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: sky/engine/core/html/HTMLIFrameElement.cpp

Issue 793393003: Move the call to mojo::View::Embed to HTMLIFrameElement (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/loader/EmptyClients.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/html/HTMLIFrameElement.cpp
diff --git a/sky/engine/core/html/HTMLIFrameElement.cpp b/sky/engine/core/html/HTMLIFrameElement.cpp
index 52da8ca7114194dddcbdeda3ddbe5548efe13d51..4717866ae70fdb1b2ee22b7751becd90631e8a11 100644
--- a/sky/engine/core/html/HTMLIFrameElement.cpp
+++ b/sky/engine/core/html/HTMLIFrameElement.cpp
@@ -66,9 +66,12 @@ void HTMLIFrameElement::createView()
return;
KURL url = document().completeURL(urlString);
- m_contentView = parentFrame->loaderClient()->createChildFrame(url);
- if (m_contentView)
- m_contentView->AddObserver(this);
+ m_contentView = parentFrame->loaderClient()->createChildFrame();
+ if (!m_contentView)
+ return;
+
+ m_contentView->Embed(mojo::String::From(url.string().utf8().data()));
+ m_contentView->AddObserver(this);
}
}
« no previous file with comments | « no previous file | sky/engine/core/loader/EmptyClients.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698