sky/engine/web/FrameLoaderClientImpl.h - Issue 793393003: Move the call to mojo::View::Embed to HTMLIFrameElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/web/FrameLoaderClientImpl.h

Issue 793393003: Move the call to mojo::View::Embed to HTMLIFrameElement (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/web/FrameLoaderClientImpl.h

diff --git a/sky/engine/web/FrameLoaderClientImpl.h b/sky/engine/web/FrameLoaderClientImpl.h

index 9a2a16ecc8f1e5fbaa4c61956521de46b1b64d67..bd1637972f1620e3a386cd2dd5d857f47c591dbf 100644

--- a/sky/engine/web/FrameLoaderClientImpl.h

+++ b/sky/engine/web/FrameLoaderClientImpl.h

@@ -73,7 +73,7 @@ public:

virtual void didStopLoading() override;

virtual void progressEstimateChanged(double progressEstimate) override;

virtual void loadURLExternally(const ResourceRequest&, NavigationPolicy, const String& suggestedName = String()) override;

- virtual mojo::View* createChildFrame(const KURL&) override;

+ virtual mojo::View* createChildFrame() override;

virtual void selectorMatchChanged(const Vector<String>& addedSelectors, const Vector<String>& removedSelectors) override;

virtual void transitionToCommittedForNewPage() override;

virtual void didChangeScrollOffset() override;

« no previous file with comments | « sky/engine/public/web/WebFrameClient.h ('k') | sky/engine/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »