sky/engine/core/loader/EmptyClients.h - Issue 793393003: Move the call to mojo::View::Embed to HTMLIFrameElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/loader/EmptyClients.h

Issue 793393003: Move the call to mojo::View::Embed to HTMLIFrameElement (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/loader/EmptyClients.h

diff --git a/sky/engine/core/loader/EmptyClients.h b/sky/engine/core/loader/EmptyClients.h

index a0a590356a5212bf7f754508d4104561bb67393e..cba0251da9b3491d57513b56319339d33c7b2929 100644

--- a/sky/engine/core/loader/EmptyClients.h

+++ b/sky/engine/core/loader/EmptyClients.h

@@ -123,7 +123,7 @@ public:

virtual void didStopLoading() override { }

virtual void loadURLExternally(const ResourceRequest&, NavigationPolicy, const String& = String()) override { }

- virtual mojo::View* createChildFrame(const KURL&) override { return nullptr; }

+ virtual mojo::View* createChildFrame() override { return nullptr; }

virtual void transitionToCommittedForNewPage() override { }