Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 792953006: Devirtualize offsetInCharacters (Closed)

Created:
5 years, 11 months ago by rwlbuis
Modified:
5 years, 11 months ago
Reviewers:
adamk
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devirtualize offsetInCharacters This method does not need to be virtual since we can just ask isCharacterDataNode(), since only for CharacterData nodes offsetInCharacters was returning true. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M Source/core/dom/CharacterData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/CharacterData.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
rwlbuis
PTAL. Unfortunately I have to ask for review again, I think https://codereview.chromium.org/152983002/ is too old ...
5 years, 11 months ago (2015-01-05 18:54:29 UTC) #2
adamk
lgtm
5 years, 11 months ago (2015-01-05 19:00:27 UTC) #3
rwlbuis
On 2015/01/05 19:00:27, adamk wrote: > lgtm Thanks! It should work this time...
5 years, 11 months ago (2015-01-05 19:30:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792953006/1
5 years, 11 months ago (2015-01-05 19:31:00 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 20:51:58 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187867

Powered by Google App Engine
This is Rietveld 408576698