Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: Source/core/dom/Node.cpp

Issue 792953006: Devirtualize offsetInCharacters (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Node.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1402 matching lines...) Expand 10 before | Expand all | Expand 10 after
1413 case DOCUMENT_NODE: 1413 case DOCUMENT_NODE:
1414 case DOCUMENT_TYPE_NODE: 1414 case DOCUMENT_TYPE_NODE:
1415 // Do nothing. 1415 // Do nothing.
1416 return; 1416 return;
1417 } 1417 }
1418 ASSERT_NOT_REACHED(); 1418 ASSERT_NOT_REACHED();
1419 } 1419 }
1420 1420
1421 bool Node::offsetInCharacters() const 1421 bool Node::offsetInCharacters() const
1422 { 1422 {
1423 return false; 1423 return isCharacterDataNode();
1424 } 1424 }
1425 1425
1426 unsigned short Node::compareDocumentPosition(const Node* otherNode, ShadowTreesT reatment treatment) const 1426 unsigned short Node::compareDocumentPosition(const Node* otherNode, ShadowTreesT reatment treatment) const
1427 { 1427 {
1428 // It is not clear what should be done if |otherNode| is nullptr. 1428 // It is not clear what should be done if |otherNode| is nullptr.
1429 if (!otherNode) 1429 if (!otherNode)
1430 return DOCUMENT_POSITION_DISCONNECTED; 1430 return DOCUMENT_POSITION_DISCONNECTED;
1431 1431
1432 if (otherNode == this) 1432 if (otherNode == this)
1433 return DOCUMENT_POSITION_EQUIVALENT; 1433 return DOCUMENT_POSITION_EQUIVALENT;
(...skipping 1026 matching lines...) Expand 10 before | Expand all | Expand 10 after
2460 node->showTreeForThis(); 2460 node->showTreeForThis();
2461 } 2461 }
2462 2462
2463 void showNodePath(const blink::Node* node) 2463 void showNodePath(const blink::Node* node)
2464 { 2464 {
2465 if (node) 2465 if (node)
2466 node->showNodePathForThis(); 2466 node->showNodePathForThis();
2467 } 2467 }
2468 2468
2469 #endif 2469 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/Node.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698