Source/core/dom/CharacterData.h - Issue 792953006: Devirtualize offsetInCharacters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/CharacterData.h

Issue 792953006: Devirtualize offsetInCharacters (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/CharacterData.h

diff --git a/Source/core/dom/CharacterData.h b/Source/core/dom/CharacterData.h

index de7d4684efc5a3ae727e550be8ce1831eba3c131..2cc75d170ba11bfbb36e44f90b976703575334fc 100644

--- a/Source/core/dom/CharacterData.h

+++ b/Source/core/dom/CharacterData.h

@@ -77,7 +77,6 @@ private:

virtual void setNodeValue(const String&) override final;

virtual bool isCharacterDataNode() const override final { return true; }

virtual int maxCharacterOffset() const override final;

- virtual bool offsetInCharacters() const override final;

void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, UpdateSource = UpdateFromNonParser, RecalcStyleBehavior = DoNotRecalcStyle);

bool isContainerNode() const = delete; // This will catch anyone doing an unnecessary check.

« no previous file with comments | « no previous file | Source/core/dom/CharacterData.cpp » ('j') | no next file with comments »