Devirtualize offsetInCharacters

Devirtualize offsetInCharacters

This method does not need to be virtual since we can just ask
isCharacterDataNode(), since only for CharacterData nodes
offsetInCharacters was returning true.

[rwlbuis, 2014-12-19 16:41:13]

rob.buis@samsung.com changed reviewers:
+ adamk@chromium.org

[rwlbuis, 2014-12-19 16:41:14]

PTAL. It basically replaces one virtual call with another virtual call, but it
does
decrease overall binary size a bit. Again, if it is not worth the trouble I'll
drop
the patch, I just had it lying around.

[adamk, 2014-12-19 18:34:15]

lgtm

This seems clear enough, and slightly reducing the set of methods one has to
think about being overridden in Node.h seems nice to me.

[rwlbuis, 2014-12-19 18:35:03]

On 2014/12/19 18:34:15, adamk wrote:
> lgtm
> 
> This seems clear enough, and slightly reducing the set of methods one has to
> think about being overridden in Node.h seems nice to me.

Thanks!

[rwlbuis, 2014-12-19 18:35:16]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-12-19 18:36:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/152983002/1

[commit-bot: I haz the power, 2014-12-19 18:36:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-19 18:36:47]

Failed to apply patch for Source/core/dom/CharacterData.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/CharacterData.cpp
  Hunk #1 FAILED at 206.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/dom/CharacterData.cpp.rej

Patch:       Source/core/dom/CharacterData.cpp
Index: Source/core/dom/CharacterData.cpp
diff --git a/Source/core/dom/CharacterData.cpp
b/Source/core/dom/CharacterData.cpp
index
2eecf98a3ba54140fd425081db25c8a1663a3824..ddea6aaabe20a0f9cb9447611c93e2ef230b1b99
100644
--- a/Source/core/dom/CharacterData.cpp
+++ b/Source/core/dom/CharacterData.cpp
@@ -206,9 +206,4 @@ int CharacterData::maxCharacterOffset() const
     return static_cast<int>(length());
 }
 
-bool CharacterData::offsetInCharacters() const
-{
-    return true;
-}
-
 } // namespace WebCore

[rwlbuis, 2014-12-19 18:45:41]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-12-19 18:45:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/152983002/120001

[commit-bot: I haz the power, 2014-12-19 18:48:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-19 18:48:39]

Try jobs failed on following builders:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/36282)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[rwlbuis, 2014-12-19 18:56:01]

Patchset #2 (id:120001) has been deleted

[rwlbuis, 2014-12-20 15:33:03]

Patchset #3 (id:160001) has been deleted

[rwlbuis, 2014-12-20 15:42:20]

Patchset #3 (id:180001) has been deleted

[rwlbuis, 2014-12-20 15:57:53]

Patchset #3 (id:200001) has been deleted

[rwlbuis, 2015-01-05 17:58:04]

Patchset #3 (id:160002) has been deleted