Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 792183004: [bindings] Use Local<> in lieu of Handle<> for the dictionary_v8.h/cpp in templates. (Closed)

Created:
6 years ago by vivekg_samsung
Modified:
6 years ago
Reviewers:
haraken, vivekg
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Use Local<> in lieu of Handle<> for the dictionary_v8.h/cpp in templates. Generated code should make use of Local<> in place of Handle<>. Making the change in the dictionary_v8.h/cpp. BUG=424445 R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187152

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
vivekg
PTAL, thanks!
6 years ago (2014-12-15 15:01:19 UTC) #2
haraken
LGTM
6 years ago (2014-12-15 15:11:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792183004/1
6 years ago (2014-12-15 15:34:46 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-15 16:41:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187152

Powered by Google App Engine
This is Rietveld 408576698