Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

Issue 792183004: [bindings] Use Local<> in lieu of Handle<> for the dictionary_v8.h/cpp in templates. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
diff --git a/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp b/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
index fbf13519e64918bd899d4a153246415661ba4328..189661495ebe5faf5fd5aecea5c3f49cbf5bd844 100644
--- a/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
+++ b/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
@@ -12,7 +12,7 @@
namespace blink {
-void V8TestDictionaryDerivedImplementedAs::toImpl(v8::Isolate* isolate, v8::Handle<v8::Value> v8Value, TestDictionaryDerivedImplementedAs& impl, ExceptionState& exceptionState)
+void V8TestDictionaryDerivedImplementedAs::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestDictionaryDerivedImplementedAs& impl, ExceptionState& exceptionState)
{
if (isUndefinedOrNull(v8Value))
return;
@@ -53,15 +53,15 @@ void V8TestDictionaryDerivedImplementedAs::toImpl(v8::Isolate* isolate, v8::Hand
}
-v8::Handle<v8::Value> toV8(const TestDictionaryDerivedImplementedAs& impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+v8::Local<v8::Value> toV8(const TestDictionaryDerivedImplementedAs& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
{
- v8::Handle<v8::Object> v8Object = v8::Object::New(isolate);
+ v8::Local<v8::Object> v8Object = v8::Object::New(isolate);
toV8TestDictionary(impl, v8Object, creationContext, isolate);
toV8TestDictionaryDerivedImplementedAs(impl, v8Object, creationContext, isolate);
return v8Object;
}
-void toV8TestDictionaryDerivedImplementedAs(const TestDictionaryDerivedImplementedAs& impl, v8::Handle<v8::Object> dictionary, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+void toV8TestDictionaryDerivedImplementedAs(const TestDictionaryDerivedImplementedAs& impl, v8::Local<v8::Object> dictionary, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
{
if (impl.hasDerivedStringMember()) {
dictionary->Set(v8String(isolate, "derivedStringMember"), v8String(isolate, impl.derivedStringMember()));
@@ -75,7 +75,7 @@ void toV8TestDictionaryDerivedImplementedAs(const TestDictionaryDerivedImplement
}
-TestDictionaryDerivedImplementedAs NativeValueTraits<TestDictionaryDerivedImplementedAs>::nativeValue(const v8::Handle<v8::Value>& value, v8::Isolate* isolate, ExceptionState& exceptionState)
+TestDictionaryDerivedImplementedAs NativeValueTraits<TestDictionaryDerivedImplementedAs>::nativeValue(const v8::Local<v8::Value>& value, v8::Isolate* isolate, ExceptionState& exceptionState)
{
TestDictionaryDerivedImplementedAs impl;
V8TestDictionaryDerivedImplementedAs::toImpl(isolate, value, impl, exceptionState);

Powered by Google App Engine
This is Rietveld 408576698