Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: Source/bindings/templates/dictionary_v8.cpp

Issue 792183004: [bindings] Use Local<> in lieu of Handle<> for the dictionary_v8.h/cpp in templates. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/dictionary_v8.h ('k') | Source/bindings/tests/results/core/V8TestDictionary.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/dictionary_v8.cpp
diff --git a/Source/bindings/templates/dictionary_v8.cpp b/Source/bindings/templates/dictionary_v8.cpp
index 6502ef65556ebdf92b93f6bf2768884e6a8a240e..daad3e9c0d6da3ff265f342421c8617368264a2f 100644
--- a/Source/bindings/templates/dictionary_v8.cpp
+++ b/Source/bindings/templates/dictionary_v8.cpp
@@ -15,7 +15,7 @@ namespace blink {
{% macro convert_and_set_member(member) %}
{% endmacro %}
-void {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Handle<v8::Value> v8Value, {{cpp_class}}& impl, ExceptionState& exceptionState)
+void {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, {{cpp_class}}& impl, ExceptionState& exceptionState)
{
if (isUndefinedOrNull(v8Value))
return;
@@ -80,9 +80,9 @@ void {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Handle<v8::Value> v8Value, {
{% endfor %}
}
-v8::Handle<v8::Value> toV8(const {{cpp_class}}& impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+v8::Local<v8::Value> toV8(const {{cpp_class}}& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
{
- v8::Handle<v8::Object> v8Object = v8::Object::New(isolate);
+ v8::Local<v8::Object> v8Object = v8::Object::New(isolate);
{% if parent_v8_class %}
toV8{{parent_cpp_class}}(impl, v8Object, creationContext, isolate);
{% endif %}
@@ -90,7 +90,7 @@ v8::Handle<v8::Value> toV8(const {{cpp_class}}& impl, v8::Handle<v8::Object> cre
return v8Object;
}
-void toV8{{cpp_class}}(const {{cpp_class}}& impl, v8::Handle<v8::Object> dictionary, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+void toV8{{cpp_class}}(const {{cpp_class}}& impl, v8::Local<v8::Object> dictionary, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
{
{% for member in members %}
if (impl.{{member.has_method_name}}()) {
@@ -107,7 +107,7 @@ void toV8{{cpp_class}}(const {{cpp_class}}& impl, v8::Handle<v8::Object> diction
{% endfor %}
}
-{{cpp_class}} NativeValueTraits<{{cpp_class}}>::nativeValue(const v8::Handle<v8::Value>& value, v8::Isolate* isolate, ExceptionState& exceptionState)
+{{cpp_class}} NativeValueTraits<{{cpp_class}}>::nativeValue(const v8::Local<v8::Value>& value, v8::Isolate* isolate, ExceptionState& exceptionState)
{
{{cpp_class}} impl;
{{v8_class}}::toImpl(isolate, value, impl, exceptionState);
« no previous file with comments | « Source/bindings/templates/dictionary_v8.h ('k') | Source/bindings/tests/results/core/V8TestDictionary.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698