Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: Source/bindings/templates/dictionary_v8.h

Issue 792183004: [bindings] Use Local<> in lieu of Handle<> for the dictionary_v8.h/cpp in templates. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/templates/dictionary_v8.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/dictionary_v8.h
diff --git a/Source/bindings/templates/dictionary_v8.h b/Source/bindings/templates/dictionary_v8.h
index 058ac5973fc273b21c22465aaff36613c21aeb7f..26eb3679b9c1d5f7124f6c84b4a8b0a99318c4cc 100644
--- a/Source/bindings/templates/dictionary_v8.h
+++ b/Source/bindings/templates/dictionary_v8.h
@@ -17,11 +17,11 @@ class ExceptionState;
class {{v8_class}} {
public:
- static void toImpl(v8::Isolate*, v8::Handle<v8::Value>, {{cpp_class}}&, ExceptionState&);
+ static void toImpl(v8::Isolate*, v8::Local<v8::Value>, {{cpp_class}}&, ExceptionState&);
};
-v8::Handle<v8::Value> toV8(const {{cpp_class}}&, v8::Handle<v8::Object>, v8::Isolate*);
-void toV8{{cpp_class}}(const {{cpp_class}}&, v8::Handle<v8::Object> dictionary, v8::Handle<v8::Object> creationContext, v8::Isolate*);
+v8::Local<v8::Value> toV8(const {{cpp_class}}&, v8::Local<v8::Object>, v8::Isolate*);
+void toV8{{cpp_class}}(const {{cpp_class}}&, v8::Local<v8::Object> dictionary, v8::Local<v8::Object> creationContext, v8::Isolate*);
template<class CallbackInfo>
inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{cpp_class}}& impl)
@@ -31,7 +31,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{cpp_class}}& im
template <>
struct NativeValueTraits<{{cpp_class}}> {
- static {{cpp_class}} nativeValue(const v8::Handle<v8::Value>&, v8::Isolate*, ExceptionState&);
+ static {{cpp_class}} nativeValue(const v8::Local<v8::Value>&, v8::Isolate*, ExceptionState&);
};
} // namespace blink
« no previous file with comments | « no previous file | Source/bindings/templates/dictionary_v8.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698