chrome/browser/sync/test/integration/bookmarks_helper.cc - Issue 791623004: bookmarks: Move BookmarkModelObserver into 'bookmarks' namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/bookmarks_helper.cc

Issue 791623004: bookmarks: Move BookmarkModelObserver into 'bookmarks' namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android + sync + cocoa fixes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/bookmark_change_processor.h ('k') | chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/bookmarks_helper.cc

diff --git a/chrome/browser/sync/test/integration/bookmarks_helper.cc b/chrome/browser/sync/test/integration/bookmarks_helper.cc

index 1e665d6cde93e3f0bbf553d85002afc50994c56e..eb152c9526a9841165b346aa327726e62f9bb753 100644

--- a/chrome/browser/sync/test/integration/bookmarks_helper.cc

+++ b/chrome/browser/sync/test/integration/bookmarks_helper.cc

@@ -67,7 +67,7 @@ class HistoryEmptyTask : public history::HistoryDBTask {

// Helper class used to wait for changes to take effect on the favicon of a

// particular bookmark node in a particular bookmark model.

-class FaviconChangeObserver : public BookmarkModelObserver {

+class FaviconChangeObserver : public bookmarks::BookmarkModelObserver {

public:

FaviconChangeObserver(BookmarkModel* model, const BookmarkNode* node)

: model_(model),

@@ -86,6 +86,8 @@ class FaviconChangeObserver : public BookmarkModelObserver {

wait_for_load_ = false;

content::RunMessageLoop();

}

+ // bookmarks::BookmarkModelObserver:

void BookmarkModelLoaded(BookmarkModel* model, bool ids_reassigned) override {

}

void BookmarkNodeMoved(BookmarkModel* model,