chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h - Issue 791623004: bookmarks: Move BookmarkModelObserver into 'bookmarks' namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h

Issue 791623004: bookmarks: Move BookmarkModelObserver into 'bookmarks' namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android + sync + cocoa fixes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/bookmarks_helper.cc ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h

diff --git a/chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h b/chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h

index 32cc395d55d6f6fd8b99f99227564b612b21dc3b..d6869df0fb69773bf61d3668fbb3c375cf28576e 100644

--- a/chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h

+++ b/chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h

@@ -21,7 +21,7 @@ class BookmarkNode;

// folder. The list also contains an extra item that shows the text

// "Choose Another Folder...".

class RecentlyUsedFoldersComboModel : public ui::ComboboxModel,

- public BookmarkModelObserver {

+ public bookmarks::BookmarkModelObserver {

public:

RecentlyUsedFoldersComboModel(BookmarkModel* model, const BookmarkNode* node);

~RecentlyUsedFoldersComboModel() override;

@@ -34,7 +34,7 @@ class RecentlyUsedFoldersComboModel : public ui::ComboboxModel,

void AddObserver(ui::ComboboxModelObserver* observer) override;

void RemoveObserver(ui::ComboboxModelObserver* observer) override;

- // Overriden from BookmarkModelObserver:

+ // Overriden from bookmarks::BookmarkModelObserver:

void BookmarkModelLoaded(BookmarkModel* model, bool ids_reassigned) override;

void BookmarkModelBeingDeleted(BookmarkModel* model) override;

void BookmarkNodeMoved(BookmarkModel* model,